-
Notifications
You must be signed in to change notification settings - Fork 108
chore(scorecard): version bump to v1.51.2 #3284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
f185bd3
617dcc0
fb6729e
a85ee01
63ebf3c
3a21168
ea0b341
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| --- | ||
| '@red-hat-developer-hub/backstage-plugin-scorecard-backend-module-dependabot': minor | ||
| '@red-hat-developer-hub/backstage-plugin-scorecard-backend-module-filecheck': minor | ||
| '@red-hat-developer-hub/backstage-plugin-scorecard-backend-module-sonarqube': minor | ||
| '@red-hat-developer-hub/backstage-plugin-scorecard-backend-module-openssf': minor | ||
| '@red-hat-developer-hub/backstage-plugin-scorecard-backend-module-github': minor | ||
| '@red-hat-developer-hub/backstage-plugin-scorecard-backend-module-jira': minor | ||
| '@red-hat-developer-hub/backstage-plugin-scorecard-backend': minor | ||
| '@red-hat-developer-hub/backstage-plugin-scorecard-common': minor | ||
| '@red-hat-developer-hub/backstage-plugin-scorecard-node': minor | ||
| '@red-hat-developer-hub/backstage-plugin-scorecard': minor | ||
| --- | ||
|
|
||
| Backstage version bump to v1.51.2 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| { | ||
| "version": "1.49.3" | ||
| "version": "1.51.2" | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -69,9 +69,9 @@ export class CatalogPage { | |
| if (baseLocale === 'en') return; | ||
|
|
||
| const displayName = getLocaleDisplayName(locale); | ||
| await this.page.getByRole('link', { name: 'Settings' }).click(); | ||
| await this.page.goto('/settings'); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] test-weakened switchToLocale switches from role-based link clicking to direct URL navigation (page.goto), bypassing UI element verification. However, this is consistent with existing page.goto() usage in loginAndSetLocale() and openCatalog() in the same file, and the method's core purpose (locale switching) remains fully tested. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] test behavior change The switchToLocale method changes from clicking the Settings link (SPA navigation) to page.goto('/settings') (full page navigation), reducing E2E test fidelity for sidebar navigation. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] test-weakened switchToLocale changed from clicking UI links to direct page.goto() calls, reducing coverage of the navigation flow. Suggested fix: Update selectors to match the new Backstage UI rather than bypassing navigation, or add assertions after goto calls. |
||
| await this.page.getByRole('button', { name: 'English' }).click(); | ||
| await this.page.getByRole('option', { name: displayName }).click(); | ||
| await this.page.locator('a').filter({ hasText: 'Home' }).click(); | ||
| await this.page.goto('/'); | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[low] test-inadequate
E2E test replaced UI-element-based navigation with direct page.goto() calls, slightly reducing coverage of navigation link presence/functionality. The affected code is test setup, not the behavior under test.