feat(intelligent-assistant): consolidate RBAC permissions into feature-linked sets - #4612
Conversation
|
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Changed Packages
|
PR Summary by QodoConsolidate Intelligent Assistant RBAC into feature permissions
AI Description
Diagram
High-Level Assessment
Files changed (17)
|
Code Review by Qodo
1. Upgrades can revoke assistant access
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4612 +/- ##
==========================================
- Coverage 62.38% 62.38% -0.01%
==========================================
Files 2607 2607
Lines 104791 104784 -7
Branches 29425 29430 +5
==========================================
- Hits 65379 65372 -7
Misses 38820 38820
Partials 592 592
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
rhdh-qodo-merge
Bot
added
documentation
|
Important The |
…e-linked sets Replace behavior-linked permission names (chat.access/use/manage, notebooks.use/manage, mcp.tools.use/manage, skills.access) with four feature-linked sets: intelligent-assistant.chat, intelligent-assistant.notebooks, intelligent-assistant.mcp.tools, and intelligent-assistant.skills. Update backend routes, frontend checks, RBAC examples, and API reports. Assisted-by: Auto Signed-off-by: Michael Valdron <mvaldron@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
3859b08 to
77cdab8
Compare
|
|
/fs-review |
|
🤖 Finished Review · ✅ Success · Started 5:21 PM UTC · Completed 5:27 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Cost: $1.15 |
ReviewVerdict: Approve This PR consolidates eight behavior-linked RBAC permissions into four feature-linked sets ( What was verified
Observations
|
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
the
ready-for-merge
…e-linked sets (redhat-developer#4612) Replace behavior-linked permission names (chat.access/use/manage, notebooks.use/manage, mcp.tools.use/manage, skills.access) with four feature-linked sets: intelligent-assistant.chat, intelligent-assistant.notebooks, intelligent-assistant.mcp.tools, and intelligent-assistant.skills. Update backend routes, frontend checks, RBAC examples, and API reports. Assisted-by: Auto Signed-off-by: Michael Valdron <mvaldron@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
…tests (#4693) Follow-up to #4612 — lock in consolidated permission names on backend routes with authorize() contract tests, selective allow/deny coverage, permission metadata registration, and a missing 403 for notebook-conversation-ids. Assisted-by: Cursor Co-authored-by: HusneShabbir <husneshabbir447@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
2 participants
Description
Consolidates Intelligent Assistant RBAC permissions from eight behavior-linked names into four feature-linked sets:
intelligent-assistant.chat,intelligent-assistant.notebooks,intelligent-assistant.mcp.tools, andintelligent-assistant.skills. Backend routes, frontend permission checks, example RBAC policies, and documentation are updated to use the new permission names and exported constants.Fixed
✔️ Checklist
Made with Cursor