Repository navigation
Fix: local build tools explain a missing dsp_asm and a /private/tmp output - #1292
Merged
Merged
Conversation
…utput `octatrack-module-packages.py --check` (run by sdk:check and pr:ready) now skips the Analog BD engine package with a note when no dsp_asm is found, as it skips the others without m68k-elf binutils or Elekloader, instead of failing with FileNotFoundError. The isolated build scripts print the fix (an output folder under $HOME) when Docker fails on a /private output. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bash scripts/build-elemod-isolated.sh(andbuild-modules-isolated.sh) with an output folder under/private/tmpfails on macOS with Docker Desktop:invalid mount config for type "bind": bind source path does not exist, with no hint that an output folder under$HOMEworks. (2) A localnpm run sdk:check(sopr:ready) withoutdsp_asmfailstest_published_module_packages_rebuild_byte_for_bytewithFileNotFoundError: 'dsp_asm', even for Rytm-only work:scripts/octatrack-module-packages.py --checkskips packages when m68k-elf binutils or the Elekloader checkout are missing, but Analog BD's engine (hook_engines.PACKAGES) also needsdsp_asmand had no such gate.scripts/octatrack-module-packages.py(not the base-pinned builder) skips an engine-carrying package with a one-line note when nodsp_asmis found (ELEKLOADER_DSP_ASM, PATH, or thenpm run upstream:toolsoctabam build, asbase_boundfinds it), like its siblings. Both isolated build scripts print "Docker may not share …: choose an output folder under $HOME." whendocker runfails on a/private/…output, keeping Docker's exit status. One sentence indocs/DEVELOPER_WORKFLOW.md("Compiled packages") now says the engine package is skipped withoutdsp_asm. Changelog entry added.octatrack-module-packages.py --checkwithoutdsp_asm: was the FileNotFoundError, now exit 0 withanalog-bassdrum needs dsp_asm …and every other package identical; withELEKLOADER_DSP_ASMset,analog-bassdrum 6272600408466c3e identical, exit 0.python3 -m unittest test_module_packages_cli test_module_packages_abi9 test_runtime_loader…byte_for_byte: OK.build-elemod-isolated.sh . /private/tmp/…/out <modwerk-source-tools id>on Docker Desktop: Docker's error, then the new hint, exit 125.npm run pr:ready: Ready.docs/DEVELOPER_WORKFLOW.md"Compiled packages" saidsdk:check"then needsdsp_asm" without saying what happens without it; it now says the engine package is skipped with a note. The Docker trap is caught by the script, so no prose.🤖 Generated with Claude Code