Repository navigation
Conversation
The AMP envelope reworked, with times on every envelope knob: AMP HLD from no hold to AUTO without cutting the attack, fine ATK, DEC, REL and HLD steps at short times (0.2 ms to 5 ms), FUNC jumps on HLD, and ENV RESET AMP (Iced-Cream's Env Reset Amp, from MrScruff's rytm-mods) with a pre-fade. Unit-tested on an MKII over USB (TESTING.md). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Compiled from a0aaa13 in the pinned toolchain (build-elemod-isolated, image 39efd52a), exported with package-elemod-recipe.mjs; --check reproduces it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ptures Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…fication record Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
It's not really my work so it doesn't feel fair to object. That said, I did already submit ENV RESET AMP two weeks ago as a modwerk module in PR #934. |
|
Thanks @npp1993, this is careful work, and the measurements in TESTING.md are great to have. @Iced-Cream, thank you for such a fair answer. #934 went into @npp1993, could you change these in one go:
Please keep it a draft until then. When it's ready I'll merge with a merge commit, because the import record pins a commit on this branch. Generated by Claude Code |
…mproved-envelopes # Conflicts: # sdk/analog-rytm-mkii/modules/README.md # src/devices/library-parity.test.ts
|
@repeat98 Happy for you to do the move. I think some other modules I submitted may have been left there in the same way |
|
Thank you, @Iced-Cream! I'll move Env Reset Amp into the library under your name, in its own pull request, and link it here. You're right about the others. Ctrl All, Main RMS and Slice Loop are waiting in Generated by Claude Code |
|
Env Reset Amp is in the library now (#1297): https://modwerk.app/analog-rytm-mkii/module/env-reset-amp/ @npp1993, that means Generated by Claude Code |
|
@Iced-Cream, Ctrl All (#1298), Main RMS (#1299) and Slice Loop (#1300) are in the library now too, under your name:
Thanks for your patience with them. Each one's TESTING.md says these exact packages haven't run on a unit with the current core yet, so if you try one on your Rytm, a line about how it went is very welcome. Generated by Claude Code |
…ote and thumbnail ENV RESET AMP and its pre-fade go back to Env Reset Amp, now in the library on its own: the two byte sites at 0x400bcf8a and 0x400ef8d6, pre-fade.c, the ENV RESET claim and its docs and release-note lines. The writer keeps only the idle skip (envelopes_gate moves to envelopes.c, still-mask at [0]). Beside Env Reset Amp the HOLD rule holds from the next block's attack record (stock's state 0 at 0x40109b5a, read in OS 1.74; upstream/README.md), so no conflict. upstream/README.md and media/thumbnail.svg are Envelopes' own; TESTING says the author where it said the owner, and drops the empty EV04 head. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…mproved-envelopes # Conflicts: # sdk/analog-rytm-mkii/modules/README.md # src/devices/library-parity.test.ts
Built by build-elemod-isolated.sh in modwerk-source-tools (39efd52a) from ed0cac2; package-elemod-recipe.mjs --check reproduces it and verify-elemod-release-exports.mjs reproduces all 49 exports. Linked on the plain base ba530f45: ramSpare 113,776 alone (EN02) and beside Env Reset Amp 1.0.0 (EN03). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ptures on EN02 The rytm-emu captures retaken on EN02 (plain base + this package) are pixel-identical to EN01's. Verification record updated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…mproved-envelopes # Conflicts: # sdk/analog-rytm-mkii/modules/README.md # src/devices/library-parity.test.ts
…mproved-envelopes # Conflicts: # sdk/analog-rytm-mkii/modules/README.md # src/devices/library-parity.test.ts
…mproved-envelopes # Conflicts: # src/devices/library-parity.test.ts
Update (7 Nov), after review: ENV RESET AMP and its pre-fade have left this module. Env Reset Amp is in the library on its own (#1297), and the two install side by side. Draft until the package has had a short run on the author's unit.
What it does
Analog Rytm MKII, OS 1.74. Improved Envelopes 0.1.0-experimental (new module, id
envelopes, category machines):It patches the amp record write (0x40109c24) and the AMP page's envelope picture call, and points stock's envelope table reads at its own tables (
ptrsites). It subscribes toev_tick, claims its UI and audio sites, and declares no conflicts. It costs 5,228 bytes of the shared mod area (plain baseba530f45: ramSpare 119,004 alone, 113,776 with this module).Review points
pre-fade.c, the ENV RESET claim, and its lines in the README, manifest, TESTING.md and release notes are gone. The amp writer keeps only its idle skip.upstream/README.md), so noconflictsentry. EN03 (base + both modules) links; the unit run will check it.upstream/README.md(origin, sites, the Env Reset Amp interaction) andmedia/thumbnail.svgare Envelopes' own now. TESTING.md says "the author" and drops the empty EV04 heading.resources.memoryBytes: 5,228 (the module is smaller without the pre-fade).2c53a220. The short unit run is pending.Evidence
envelopes-0.1.0-experimental-os1.74.elemod(3c5016ae…), built fromed0cac20in the pinned toolchain (build-elemod-isolated.sh).--checkreproduces it, andverify-elemod-release-exports.mjsreproduces all 49 current exports. Pinned insdk/imports/elekloader-envelopes-2026-11-07.json(commit2c53a220) and vendored; record indocs/verification/2026-11-07-rytm-improved-envelopes.md.media/capture.json.Checklist
What the guides lacked or got wrong:
build-elemod-isolated.shfails when its output folder is under/private/tmp(Docker Desktop cannot mount it), and a localsdk:checkneedsdsp_asmon PATH. The tools now say so (Fix: local build tools explain a missing dsp_asm and a /private/tmp output #1292, merged).package-elemod-recipe.mjswon't overwrite an existing package (EEXIST). To rebuild an unreleased version, delete the file first.elekloader:update --overlaycan answer 404 for a few minutes after a push, even with the PR open, while GitHub's raw CDN catches up. Retry.Validation:
npm run pr:ready: Ready (withdsp_asmon PATH).🤖 Generated with Claude Code