Repository navigation
Analog Rytm MKII: Ctrl All 1.2.0 moves into the library - #1298
Merged
Merged
Conversation
Moves Iced-Cream's Ctrl All 1.2.0 (an elemod port of MrScruff's rytm-mods mod, in rytm2_mods) from _submissions/ into modules/ctrl-all, code unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Compiled in the pinned modwerk-source-tools image from a clean checkout of 4e85d71 and exported with package-elemod-recipe.mjs (--check reproduces it). Its .run, sites, symbols and relocations equal rytm2_mods v1.2's release object, apart from the runs that object takes from the stock OS. Adds the import record, release notes, the library list line and TESTING.md's library package section. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The elekloader record pins the package at f16f4d9; elekloader:update --overlay fetched it into the vendored catalogue. The library parity and planBuild tests list it, and the verification record says what was built and what has not run on a unit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
repeat98
added a commit
that referenced
this pull request
Nov 7, 2026
Keeps Ctrl All (#1298) beside Main RMS in the modules README and the library parity test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
repeat98
added a commit
that referenced
this pull request
Nov 7, 2026
Keeps Ctrl All (#1298) beside Slice Loop in the modules README and the library parity test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves Iced-Cream's Ctrl All 1.2.0 from
_submissions/(merged in #936) into the library, so it appears on the site once merged. It is the elemod port (rytm2_mods v1.2,afd461d) of MrScruff's rytm-mods0014-ctrl-all: hold TRK and turn a knob on a sound page or the TRIG page, and the same step goes to that parameter on all twelve sound tracks. Version stays 1.2.0 and the code is unchanged. Needs repeat98's first-release approval.Author's OK: Iced-Cream agreed to our doing the move: #1291 (comment)
sdk/analog-rytm-mkii/modules/ctrl-all/withgit mv. The manifest,build.json, source, include, media, evidence and every credit line are unchanged (author Iced-Cream; MrScruff's original, published in rytm-mods-src with permission; irpina's core). The submission already hadtests.documentation, the tutorial, 3 rytm-emu captures with their record and measured memory, so the manifest needed nothing more. The modules README lists it..elemod1d0c2141922e6c466d2ba4f249af3ad83f66e7fdac18d47dc5f94edce301973cinsdk/imports/packages/ctrl-all/, recorded insdk/imports/ctrl-all-2026-11-07.json, pinned bysdk/imports/elekloader-ctrl-all-2026-11-07.json(commitf16f4d99) and vendored throughelekloader:update -- --overlay. Built bybuild-elemod-isolated.sh(modwerk-source-tools28323550) from a clean checkout of4e85d714(the move alone).package-elemod-recipe.mjs --checkreproduces it, andverify-elemod-release-exports.mjsreproduces all 45 exports..run, sites, symbols and relocations equal rytm2_mods v1.2's release object (cc7d1b3c…bc7b). Where that object takes 14 runs (122 bytes, at most 10 in a row) from the stock OS at link time, this package carries the bytes compiled from the source, as Filter Hz's package does.sdk/imports/rytm2-mods-ctrl-all-afd461d.jsonnames module-relative paths, so the move changes nothing in it and its hashes stand (sdk:imports:checkgreen).src/community/module-changelogs/analog-rytm-mkii-ctrl-all.json, one 1.2.0 entry, 5 lines.ctrl-all1.2.0;digi-build.test.tsplans it beside Env Reset Amp and Filter Hz on the plain base.docs/verification/2026-11-07-rytm-ctrl-all-library.md.jmpat0x400378c2inparam_apply_delta. No library module or base variant patches it, and its claim (ui:TRK + knob on sound and TRIG pages) is no other module's. The Rytm SDK guide names ctrl-all's turn hook among the 0.3 mods that link with core 0.7 as with 0.3. Parameters other modules add stay single-track, as its limitations say.pr:ready's board check says a move out of_submissions/adds nothing that needs a claim, so it ran withMODWERK_BOARD=off, as for Env Reset Amp (Analog Rytm MKII: Env Reset Amp 1.0.0 moves into the library #1297).Links: #936, #1297. Merge with a merge commit, not a squash, so the pinned commit
f16f4d99stays onmain. If I mergemaininto this branch to clear a conflict, the pin stays in the branch history and the same applies.What the guides lacked: nothing wrong. One gap, left out of this module release:
ELEMOD_SOURCE_BUILDS.mddoes not say that an upstream release object may take runs from the stock OS (stockparts) while Modwerk's export carries the compiled bytes, so comparing an export with the author's object means comparing the hex parts at their offsets.Validation commands and results:
npm run module:doctor -- ctrl-all: manifest, category guide, browser builder and module rules greenMODWERK_BOARD=off npm run pr:ready: Readynode scripts/package-elemod-recipe.mjs … --check,node scripts/verify-elemod-release-exports.mjs <build>: reproduced (45 exports)npx vitest run src/devices/library-parity.test.ts src/engine/elekloader/digi-build.test.ts: 51 passed🤖 Generated with Claude Code