Skip to content

Analog Rytm MKII: Env Reset Amp 1.0.0 moves into the library - #1297

Merged
repeat98 merged 3 commits into
mainfrom
claude/rytm-env-reset-amp-library
Nov 7, 2026
Merged

repeat98 merged 3 commits into
mainfrom
claude/rytm-env-reset-amp-library

Conversation

@repeat98

@repeat98 repeat98 commented Nov 7, 2026

Copy link
Copy Markdown
Owner

Moves Iced-Cream's Env Reset Amp 1.0.0 from _submissions/ (merged in #934) into the library, so it appears on the site once merged. It is the elemod port (rytm2_mods v1.2, afd461d) of MrScruff's rytm-mods 0015-env-reset-amp: SOUND SETTINGS > ENV RESET steps OFF, AMP, FILTER, AMP+FILT, and with AMP set the amp envelope restarts from silence on every trig, so AMP ATK is heard on every hit. Version stays 1.0.0 and the code is unchanged. Needs repeat98's first-release approval.

Author's OK: Iced-Cream agreed to our doing the move: #1291 (comment)

  • Moved to sdk/analog-rytm-mkii/modules/env-reset-amp/ with git mv. Manifest, build.json, source, media, evidence and every credit line are unchanged (author Iced-Cream; MrScruff's original, published in rytm-mods-src with permission; irpina's core). The submission already had tests.documentation, the tutorial, three rytm-emu captures with their record, the README's seven sections and measured memory (52 bytes), so the manifest needed nothing more. Modules README lists it.
  • Package: source-only OS 1.74 .elemod fadea586838ab574ee69a3f1d524cfc981404e3cee7745593ab02eda0e23e993 in sdk/imports/packages/env-reset-amp/, recorded in sdk/imports/env-reset-amp-2026-11-07.json, pinned by sdk/imports/elekloader-env-reset-amp-2026-11-07.json (commit f9953205) and vendored through elekloader:update -- --overlay. Built by build-elemod-isolated.sh (modwerk-source-tools 28323550) from a clean checkout of 787719d2 (the move alone); package-elemod-recipe.mjs --check reproduces it, and verify-elemod-release-exports.mjs reproduces all 44 exports. Its .run (52 bytes), three sites and symbols are identical to rytm2_mods v1.2's release object 881bcfed…40d1.
  • Import record: sdk/imports/rytm2-mods-env-reset-amp-afd461d.json names module-relative paths, so the move changes nothing in it and its hashes stand (sdk:imports:check green).
  • Release notes: src/community/module-changelogs/analog-rytm-mkii-env-reset-amp.json, one 1.0.0 entry, four lines.
  • Tests: library-parity lists env-reset-amp 1.0.0; digi-build.test.ts plans it beside Filter Hz and Temp Save on the plain base.
  • TESTING.md: the line saying it is a submission until the browser can build it now says it waited there; a new "Library package" section records the build above. The author's hardware reports stay as reported.
  • Evidence: as reported by the author, on an Analog Rytm MKII with OS 1.74: R8T2, C3A4, SXH4 and ERH4 (alone), all with core-ar2 0.3 or earlier. This package's own bytes have not been linked against a stock OS file, flashed from the site or run on the Modwerk base (core-ar2 0.7). Record: docs/verification/2026-11-07-rytm-env-reset-amp-library.md.
  • Compatibility: patches 0x400bcf8a, 0x400ef8d6 and 0x40109b70; no library module or the base patches them. Analog Rytm MKII: Improved Envelopes 0.1.0-experimental #1291 (Envelopes) patches the first two and is left to its author.
  • Agent board: not claimed. pr:ready's board check says a move out of _submissions/ adds nothing that needs a claim, while module:doctor counts modules/env-reset-amp as a new folder and stays red on its board line. A direct npm run board -- claim was refused by the permission check here, so pr:ready ran with MODWERK_BOARD=off; claim it with npm run board -- claim module analog-rytm-mkii/env-reset-amp if you want doctor green.

Links: #934, #1291. Merge with a merge commit, not a squash, so the pinned commit f9953205 stays on main.

What the guides lacked: nothing wrong. One gap for the next moves: ELEMOD_SOURCE_BUILDS.md and the Rytm guide do not say that the exported package carries the manifest's presentation.summary as its description, so the summary has to be final before the build; changing it afterwards keeps the released text (reproducesExport). Not worth a guide line on its own, so no guide edit.

Validation commands and results:

  • npm run module:doctor -- env-reset-amp: manifest, category guide, browser builder and module rules green; board claim red (above)
  • MODWERK_BOARD=off npm run pr:ready: Ready (check passed in 238 s; the branch is level with main)
  • node scripts/package-elemod-recipe.mjs … --check, node scripts/verify-elemod-release-exports.mjs <build>: reproduced
  • npx vitest run src/devices/library-parity.test.ts src/engine/elekloader/digi-build.test.ts: 50 passed

🤖 Generated with Claude Code

repeat98 and others added 3 commits November 7, 2026 14:16
Moves Iced-Cream's Env Reset Amp 1.0.0 (MrScruff's rytm-mods
0015-env-reset-amp, elemod port in rytm2_mods) from _submissions/ into
modules/env-reset-amp, code unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Compiled in the pinned modwerk-source-tools image from a clean checkout
of 787719d and exported with package-elemod-recipe.mjs (fadea586,
--check reproduces it). Its .run, sites and symbols equal rytm2_mods
v1.2's release object. Adds the import record, release notes, the
library list line and TESTING.md's library package section.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The elekloader record pins the package at f995320; elekloader:update
--overlay fetched it into the vendored catalogue. The library parity
and planBuild tests list it, and the verification record says what
was built and what has not run on a unit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant