Repository navigation
Analog Rytm MKII: Env Reset Amp 1.0.0 moves into the library - #1297
Merged
Merged
Conversation
Moves Iced-Cream's Env Reset Amp 1.0.0 (MrScruff's rytm-mods 0015-env-reset-amp, elemod port in rytm2_mods) from _submissions/ into modules/env-reset-amp, code unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Compiled in the pinned modwerk-source-tools image from a clean checkout of 787719d and exported with package-elemod-recipe.mjs (fadea586, --check reproduces it). Its .run, sites and symbols equal rytm2_mods v1.2's release object. Adds the import record, release notes, the library list line and TESTING.md's library package section. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The elekloader record pins the package at f995320; elekloader:update --overlay fetched it into the vendored catalogue. The library parity and planBuild tests list it, and the verification record says what was built and what has not run on a unit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves Iced-Cream's Env Reset Amp 1.0.0 from
_submissions/(merged in #934) into the library, so it appears on the site once merged. It is the elemod port (rytm2_mods v1.2,afd461d) of MrScruff's rytm-mods0015-env-reset-amp: SOUND SETTINGS > ENV RESET steps OFF, AMP, FILTER, AMP+FILT, and with AMP set the amp envelope restarts from silence on every trig, so AMP ATK is heard on every hit. Version stays 1.0.0 and the code is unchanged. Needs repeat98's first-release approval.Author's OK: Iced-Cream agreed to our doing the move: #1291 (comment)
sdk/analog-rytm-mkii/modules/env-reset-amp/withgit mv. Manifest,build.json, source, media, evidence and every credit line are unchanged (author Iced-Cream; MrScruff's original, published in rytm-mods-src with permission; irpina's core). The submission already hadtests.documentation, the tutorial, three rytm-emu captures with their record, the README's seven sections and measured memory (52 bytes), so the manifest needed nothing more. Modules README lists it..elemodfadea586838ab574ee69a3f1d524cfc981404e3cee7745593ab02eda0e23e993insdk/imports/packages/env-reset-amp/, recorded insdk/imports/env-reset-amp-2026-11-07.json, pinned bysdk/imports/elekloader-env-reset-amp-2026-11-07.json(commitf9953205) and vendored throughelekloader:update -- --overlay. Built bybuild-elemod-isolated.sh(modwerk-source-tools28323550) from a clean checkout of787719d2(the move alone);package-elemod-recipe.mjs --checkreproduces it, andverify-elemod-release-exports.mjsreproduces all 44 exports. Its.run(52 bytes), three sites and symbols are identical to rytm2_mods v1.2's release object881bcfed…40d1.sdk/imports/rytm2-mods-env-reset-amp-afd461d.jsonnames module-relative paths, so the move changes nothing in it and its hashes stand (sdk:imports:checkgreen).src/community/module-changelogs/analog-rytm-mkii-env-reset-amp.json, one 1.0.0 entry, four lines.env-reset-amp1.0.0;digi-build.test.tsplans it beside Filter Hz and Temp Save on the plain base.docs/verification/2026-11-07-rytm-env-reset-amp-library.md.0x400bcf8a,0x400ef8d6and0x40109b70; no library module or the base patches them. Analog Rytm MKII: Improved Envelopes 0.1.0-experimental #1291 (Envelopes) patches the first two and is left to its author.pr:ready's board check says a move out of_submissions/adds nothing that needs a claim, whilemodule:doctorcountsmodules/env-reset-ampas a new folder and stays red on its board line. A directnpm run board -- claimwas refused by the permission check here, sopr:readyran withMODWERK_BOARD=off; claim it withnpm run board -- claim module analog-rytm-mkii/env-reset-ampif you want doctor green.Links: #934, #1291. Merge with a merge commit, not a squash, so the pinned commit
f9953205stays onmain.What the guides lacked: nothing wrong. One gap for the next moves:
ELEMOD_SOURCE_BUILDS.mdand the Rytm guide do not say that the exported package carries the manifest'spresentation.summaryas itsdescription, so the summary has to be final before the build; changing it afterwards keeps the released text (reproducesExport). Not worth a guide line on its own, so no guide edit.Validation commands and results:
npm run module:doctor -- env-reset-amp: manifest, category guide, browser builder and module rules green; board claim red (above)MODWERK_BOARD=off npm run pr:ready: Ready (check passed in 238 s; the branch is level withmain)node scripts/package-elemod-recipe.mjs … --check,node scripts/verify-elemod-release-exports.mjs <build>: reproducednpx vitest run src/devices/library-parity.test.ts src/engine/elekloader/digi-build.test.ts: 50 passed🤖 Generated with Claude Code