fix(instrumentation-js): repair LangChain, LlamaIndex, and Mastra OTel 2.x spans - #367
Merged
fran3cc merged 2 commits intoAug 21, 2026
Conversation
Nightingalelyy
marked this pull request as ready for review
August 15, 2026 14:40
Contributor
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
Nightingalelyy
marked this pull request as draft
August 18, 2026 03:32
Nightingalelyy
marked this pull request as ready for review
August 19, 2026 15:58
Contributor
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
package builds passed for LangChain, LlamaIndex, and Mastra
focused tests passed: 13 + 6 + 4 (23 total)
npm pack --dry-run passed for all three packages
release inventory and release-intent validation passed
complete locally linked example suites passed with marker
otel2-fix-js-group-02-20260815T075000ZRespan MCP audit passed for 42 traces and 124 full span records, including tree integrity, content, model/token data, tool execution, expected errors, grouping, and duplicate checks
Contribution re-audit against every current document under
contribution/passed afterf37d4a8: LangChain text LLMs use canonicalchatrequest type, automatic span-kind and direct model/input/output/token/tool aliases are absent, and tool definitions/current-turn calls use canonical JSON attributes.Fresh correction validation: all three package builds and 23/23 focused tests passed; release inventory/intents and diff checks passed; marker
otel2-pr367-contract-correction-20260818T133700Zproduced 3/3 representative LangChain traces and all 3 full records were inspected for chat/text/tool semantics, content, usage, aliases, and duplicates.External follow-ups
Companion examples