fix(instrumentation-py): repair LiveKit, LlamaIndex, and Marqo OTel 2.x spans - #383
Merged
fran3cc merged 2 commits intoAug 21, 2026
Conversation
Nightingalelyy
marked this pull request as ready for review
August 19, 2026 15:59
Contributor
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LLMStreamcalls as streaming, derive provider identity from the LiveKit plugin/model instead of the gateway host, preserve canonical tool schema/calls, and remove temporary transport attributes before exportBaseTool.call/acallexecutions as tools; keep orchestration phases as tasks and cover a registered real ReAct runtime with exactly onemultiply_numbersexecutionValidation
focused tests: LiveKit 8/8, LlamaIndex 24/24 plus one credential-gated skip, Marqo 3/3 (35 passed, 1 skipped)
Ruff check and format-check passed for every changed Python file
wheels built successfully for all three packages
release inventory, release-intent, missing-intent, and diff checks passed
all validation environments resolved the three instrumentations and local Respan core packages through editable local
direct_url.jsonentriescorresponding examples passed 12/12 with marker
otel2-fix-py-group-17-20260817T111735ZRespan MCP: 12 connected traces / 58 full records; one root per tree, matching counts, no duplicate IDs or orphan parents; every full record inspected for hierarchy, type, content, model/provider, usage, tools, errors, grouping, and exact marker
final LiveKit correction rerun
otel2-fix-py-group-17-livekit-clean-20260817T112900Z: 5 traces / 7 records, provideropenai,stream=true, exact usage, complete tool schema/call, and no internal transport-key leakContribution re-audit against every current document under
contribution/passed after2b64d6c: LlamaIndex text-completion events use the permittedtextlog type and canonicalllm.request.type=chat.Fresh correction validation: LiveKit 8/8, LlamaIndex 24/24 plus 1 skipped, and Marqo 3/3 passed; LlamaIndex wheel, release inventory/intents, formatting/import, and diff checks passed; marker
otel2-pr-contract-corrections-20260818T133300Zproduced 1 connected LlamaIndex trace / 2 full records, both inspected.External follow-ups
tools/tool_callsarrays remain empty despite canonical tool attributes/contenterror_count=0Companion examples