Skip to content

fix(instrumentation-py): repair MCP, Microsoft Agent Framework, and Milvus OTel 2.x spans - #384

Merged
fran3cc merged 1 commit into
respanai:mainfrom
Nightingalelyy:fix/otel2-py-mcp-ms-agent-milvus
Aug 21, 2026
Merged

fix(instrumentation-py): repair MCP, Microsoft Agent Framework, and Milvus OTel 2.x spans#384
fran3cc merged 1 commit into
respanai:mainfrom
Nightingalelyy:fix/otel2-py-mcp-ms-agent-milvus

Conversation

@Nightingalelyy

@Nightingalelyy Nightingalelyy commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • constrain MCP to its verified 1.x SDK line, harden bounded/privacy-safe schema serialization, share patch ownership across instrumentors, and add real stdio propagation/failure coverage
  • preserve Microsoft Agent Framework tool definitions/calls and provider HTTP status, normalize nested paths, share processor/patch ownership, and add real framework success/failure coverage
  • stabilize Milvus JSON output and endpoint identity, pin the verified Lite test pair, and cover real sync/async success and failure exports

Release Intent.

  • adds .release-intents/20260817-mcp-microsoft-agent-framework-milvus-otel2.json
  • requests patch releases for respan-instrumentation-mcp, respan-instrumentation-microsoft-agent-framework, and respan-instrumentation-milvus

Validation

  • Added and validated the release intent; release inventory passes and no changed package is missing an intent

  • Focused tests: MCP 10/10, Microsoft Agent Framework 15/15, Milvus 3/3

  • Ruff check and format-check pass for all changed package source and tests

  • All three package wheels build successfully

  • Matching local-editable examples pass 10/10 under otel2-fix-py-group-18-20260817T121654Z

  • Respan MCP audit opened all 10 trace trees and all 49 full records; roots, parents, IDs, content, tools, usage, errors, grouping, and duplicates were checked

  • Full source and paired-example diffs were audited against every applicable document under contribution/; canonical span fields, OTel attribute shapes, release-intent/version ownership, and package boundaries have no remaining package-owned violation.

External follow-ups

  • MCP and Milvus native OTel ERROR spans retain their diagnostic content but are still projected as success/200 after backend ingestion
  • Agent Framework common-only agent rows remain unknown-model in the UI and canonical tool attributes do not populate the platform's top-level tool arrays
  • Agent Framework native bookkeeping spans expose only structural metadata upstream; bounded semantic input/output is carried by the surrounding workflow and user task

Companion examples

@Nightingalelyy Nightingalelyy changed the title fix(instrumentation): repair MCP, Microsoft Agent Framework, and Milvus OTel 2.x spans fix(instrumentation-py): repair MCP, Microsoft Agent Framework, and Milvus OTel 2.x spans Aug 18, 2026
@Nightingalelyy
Nightingalelyy marked this pull request as ready for review August 19, 2026 15:59

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@fran3cc
fran3cc merged commit 962deef into respanai:main Aug 21, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants