You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Follow-up from Claude's merge review of #894 (merged as 590a785). This did not block merge.
The Windows branch is reasoned, not observed. On Windows, the torn-read reader holds user_data.json open and can block Files.move. In that case the race test now treats the run as inconclusive (IS_WINDOWS && decodedForms.size <= 1). Since ci: run the Windows legs only for PRs into main #1631, dev PRs run only ubuntu, so this branch has never actually run in CI. It will first run on a PR into main. Check the first Windows run on a main-bound PR and confirm the branch behaves as intended.
The skip is silent. A Windows run that proved nothing passes with no trace in the output. Log a line (or collect a note and print it at the end) so "inconclusive on this leg" shows up in the test log.
Nit: the empty if branch around UserDataStorageMergeTest.kt:441-450 is comment-only. Invert the condition so it doesn't read as unfinished.
Follow-up from Claude's merge review of #894 (merged as 590a785). This did not block merge.
user_data.jsonopen and can blockFiles.move. In that case the race test now treats the run as inconclusive (IS_WINDOWS && decodedForms.size <= 1). Since ci: run the Windows legs only for PRs into main #1631, dev PRs run only ubuntu, so this branch has never actually run in CI. It will first run on a PR into main. Check the first Windows run on a main-bound PR and confirm the branch behaves as intended.ifbranch aroundUserDataStorageMergeTest.kt:441-450is comment-only. Invert the condition so it doesn't read as unfinished.