Repository navigation
fix(security): use constant-time byte comparison for process token revocation (#1039) - #1085
KhushiTrivediii wants to merge 10 commits into
Conversation
… PEM keys in McpArgumentSanitizer (risa-labs-inc#886)
… EditorServiceImpl (risa-labs-inc#885)
…ogs, and fix reload state in BrowserServiceImpl (risa-labs-inc#911)
…o in ChromiumAutoDownloader (risa-labs-inc#910)
|
Cross-referencing for the maintainer's triage — the file list here is 25 files, but the title describes a one-line change ( The diff re-implements fixes that are already open PRs by other contributors. Spot-verified against the diffs:
Two of this author's other open PRs carry the same 25-file list (#1102 loopback binding shows the identical file set under a different one-line title), which suggests both were branched from the same working tree and the titles describe only a fraction of what each diff changes. For the merge decision: the PR's nominal subject (constant-time token compare) is sound and covered better by #1040 (which cites its own issue, #1039's predecessor, and carries the token-regression tests). Everything else in this diff duplicates open PRs whose authors filed the underlying issues, wrote the first fixes, and have test suites in review. A maintainer merging this as-titled would unknowingly land twenty-four files of parallel implementations that then conflict with every one of those PRs at rebase. Suggested action: either rebase this branch down to its stated subject only ( |
|
Thanks so much for this contribution, @KhushiTrivediii - the work here is genuinely appreciated, and it's clear real care went into it. This overlaps with #1040 ("fix(ipc): compare the revoke-if-current token in constant time (#1039)"), which is further along in review and will carry this change forward. To keep review attention focused, I'm closing this one in favor of #1040 - please do review and follow that PR, and you're very welcome to pick up any part of it that still needs help or take on another open issue. Your contribution credit is noted here, and anything unique in this branch that #1040 misses is still welcome as a follow-up. Thanks again for contributing to BossConsole! |
Fixes #1039.
Replaces short-circuiting String == comparison with constant-time byte comparison (MessageDigest.isEqual) in ProcessTokenRegistry.revokeIfCurrent.