Skip to content

test: organize settings sync cases without changing discovery - #1570

Closed
risu729 wants to merge 1 commit into
mainfrom
refactor/service-settings-sync-tests-20261112
Closed

risu729 wants to merge 1 commit into
mainfrom
refactor/service-settings-sync-tests-20261112

Conversation

@risu729

@risu729 risu729 commented Nov 12, 2026 •

Copy link
Copy Markdown
Owner

The settings-sync test entry mixed post-pairing synchronization, vault policies, profile changes and personal-detail links. Keep the sole discovered entry, all ten original suite wrappers and every fixture/helper/local initialization in its original scope; extract only three coherent case groups into passive synchronous registrars outside production coverage.

The entry is 896 lines; registrars are 819, 250 and 320 lines, with a 94-line erased context. All runtime imports and shared references remain owned by the entry. Callbacks, assertions, tables, comments, raw literals and registration order are preserved. Remove only this entry's line-limit exemption and document ownership. Continues the approved refactoring work.

Validation at final head:

  • Fresh independent source review found no issues. Full expanded AST/raw tokens/comments, fixture lifetimes and imported binding owners match the original. Types are erased and portable.
  • Original 95/95 cases pass in 986 ms; the actual service task passes 769 cases across 20 files with coverage in 17.36 s. All 95 expanded IDs, full titles, order and outcomes plus ten suite IDs/nesting match exactly.
  • All 20 discovered service entries remain unchanged. Actual coverage contains 258 production files and no helper modules; runner/discovery/coverage configuration is unchanged.
  • Extension typecheck, scoped static checks, docs validation, full CI and CodeQL pass, including all six packaged browser shards.
  • Every Verify task matches the actual tested-parent baseline: 9,186 Vitest cases across 274 files plus 73 tool tests; components retain 1,814 cases across 108 files. The tested merge includes 30 newer diagnostics/login-attempt/lint/docs paths with no owning service source/test difference.
  • This run was slower in Verify, 190 → 260 s (runtime 151.49 → 200.43 s); service task 34.55 → 50.99 s and settings entry 1.315 → 2.302 s. Unchanged API, login and Bitwarden tasks also slowed. Components were 217 → 151 s. These individual observations do not isolate a causal performance effect or establish zero regression.

No real-account validation was performed. Leave open for owner review; no merge or auto-merge.

@risu729 risu729 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fresh independent source review: no actionable findings at the reviewed head against the original main base.

Independently expanded all three registrars and proved complete AST plus exact raw token/comment equality against the actual Git baseline. Seven each tables expand to the original 95 tests from 85 declarations, retaining ten describe scopes, 307 expect calls and eight templates. All forwarded imports, constants and functions retain identity and initialization; suite-local fixtures stay before their original case spans, with no reassigned capture, receiver or lexical this/arguments dependency. Helpers are passive functions with type-only imports; the erased entry fixture type import adds no runtime cycle and no absolute path exists. Discovery/coverage/task configuration remains unchanged, helpers stay outside production coverage, only this entry's exemption is removed, and docs match the implementation.

Runtime and CI verification are separate evidence. The reviewer made no edits, runtime/browser tests or real-account actions.

risu729 commented Nov 12, 2026

Copy link
Copy Markdown
Owner Author

Merged as #1578. That PR keeps these commits and adds:

  • direct vitest and production imports in the case modules, so the registrars receive only fixtures
  • its own docs section, which drops the "sole entry" claim
  • a merge of main

The collected test IDs, and their order, match main (95 tests).


Generated by Claude Code

@risu729 risu729 closed this Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant