Skip to content

test: organize settings sync cases without changing discovery - #1578

Merged
risu729 merged 3 commits into
mainfrom
claude/project-thread-ei232v
Nov 12, 2026
Merged

risu729 merged 3 commits into
mainfrom
claude/project-thread-ei232v

Conversation

@risu729

@risu729 risu729 commented Nov 12, 2026

Copy link
Copy Markdown
Owner

This replaces #1570. It keeps Codex's commits unchanged and adds one fix commit and a merge of main.

The fix commit:

  • Direct imports. The case modules now import it, expect, vi, syncedSettings, mergeSyncedSettings and the MAX_SETTINGS_* constants directly. They no longer arrive through the fixture object, which now carries only fixtures, the same as the other registrars under test/. The entry drops the two constants it only passed along.
  • Import order. The registrar imports in the entry now come after the local imports.
  • Docs. The paragraph moves into its own section after the other test organization sections and now describes the layout rather than the change. It no longer calls settings-sync.test.ts the sole settings sync entry, because settings-sync.lost-base.test.ts and settings-sync.property.test.ts are entries too.

The merge of main resolves two conflicts:

Verification

  • Test discovery. The collected test IDs on main and on this branch are identical, including their order: 95 tests, all passing.
  • Independent review. A reviewer pasted each registrar's body back in place of its call. Apart from the exported fixture type, the result is identical to origin/main. There are no hooks or mocks, and every describe-local fixture is a const.
  • Checks. oxlint, oxfmt, rumdl and the extension type check all pass.

Generated by Claude Code

risu729 and others added 3 commits November 12, 2026 21:43
Pass only fixtures through the registrars, keep the entry's imports in order, and
give the layout its own docs section beside the other test organization notes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011PUTx3w1HVYZp73fQasU3g
# Conflicts:
#	.oxlintrc.json
#	docs/development.md
@risu729 risu729 self-assigned this Nov 12, 2026
@risu729
risu729 merged commit 984ae59 into main Nov 12, 2026
14 checks passed
@risu729
risu729 deleted the claude/project-thread-ei232v branch November 12, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants