Repository navigation
test: organize settings sync cases without changing discovery - #1578
Merged
Merged
Conversation
Pass only fixtures through the registrars, keep the entry's imports in order, and give the layout its own docs section beside the other test organization notes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011PUTx3w1HVYZp73fQasU3g
# Conflicts: # .oxlintrc.json # docs/development.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces #1570. It keeps Codex's commits unchanged and adds one fix commit and a merge of main.
The fix commit:
it,expect,vi,syncedSettings,mergeSyncedSettingsand theMAX_SETTINGS_*constants directly. They no longer arrive through the fixture object, which now carries only fixtures, the same as the other registrars undertest/. The entry drops the two constants it only passed along.settings-sync.test.tsthe sole settings sync entry, becausesettings-sync.lost-base.test.tsandsettings-sync.property.test.tsare entries too.The merge of main resolves two conflicts:
.oxlintrc.json: test: organize recipe sync cases without changing discovery #1577 had removed the adjacentrecipes.test.tsexemption, so both lines are dropped.Verification
origin/main. There are no hooks or mocks, and every describe-local fixture is aconst.Generated by Claude Code