Skip to content

refactor: organize login badge test cases - #1581

Closed
risu729 wants to merge 1 commit into
mainfrom
refactor/login-badge-tests-20261112
Closed

risu729 wants to merge 1 commit into
mainfrom
refactor/login-badge-tests-20261112

Conversation

@risu729

@risu729 risu729 commented Nov 12, 2026 •

Copy link
Copy Markdown
Owner

The badge test entry exceeded the 1,000-line limit and mixed presentation, navigation, persistence, and status-recording cases. Keep its hoisted browser mock, hooks, six original scopes, fixtures, and helper initialization positions in the entry, and register the unchanged cases through four passive modules outside production coverage. The entry is 806 lines; the modules are 371, 400, 263, and 251 lines. Remove only the target max-lines exemption and document the arrangement.

Independent source review of the final head found no issues: full AST reconstruction, 67 comments, 16,979 raw tokens including punctuation, literal/template text, all 15 captures and all 20 import owners match the original. The 95 declarations expand to 134 cases in six suites. All five TypeScript blobs are byte-identical across the documentation-only rebase.

Separate runtime verification injected original Git source at the identical module path: baseline 134/134 passed (1.33s), then the existing full login task with coverage passed 2,723/2,723 across 107 files (207.66s). Case IDs, full titles, order, results, suite IDs and explicit parent relationships match. Discovery remains 107 entries; coverage contains 258 production files and no badge entry/helpers. Extension type checking, scoped checks and documentation checks pass.

Final CI passed Verify, Orders and components, all six browser shards and CI Check. CodeQL passed both analyses. The actual tested merge tree equals the final head with the expected base. Every task count matches that base's CI: Verify 9,186 tests/274 files plus 73 tool tests; components 1,814 tests/108 files. Timings are mixed: Verify 177→262s, runtime 137.38→200.17s and login 89.86→128.06s were slower, alongside all fifteen Verify tasks; affected entry 1.129→0.727s and component job 181→171s were faster. These are single-run observations, not causal speedup or zero-regression claims.

Part of the approved refactor scope. No production behavior, assertions, timeouts, discovery or coverage rules changed. No merge or auto-merge requested.

@risu729 risu729 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent source review of the final head: no actionable findings.

Expanding the four registrars reproduces the full original AST, all 16,979 raw tokens including punctuation, every literal/template and all 67 comments. The six describe scopes and 95 declarations expanding to 134 cases are preserved. All 15 captures retain const/function identity and lifetime, without reassignment or this/arguments dependencies; later initializers remain untouched.

Registrars only register cases synchronously. Entry type imports are erased, with no runtime cycle or machine imports. The first runtime import order (vitest, i18n, badge, time) and all 20 imported binding owners match. All source blobs remain byte-identical across rebase; discovery, coverage and tasks are unchanged. The documentation conflict resolution preserves upstream paragraphs and adds only the accurate badge paragraph; only the target lint exception is removed.

This review was source-only; runtime and final CI verification are separate.

risu729 commented Nov 12, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #1588, which keeps these commits and adds the review fixes (*-cases.ts module names, a shared context.ts, import and type placement in the entry, and a docs section of its own placed after the sibling sections). #1588 is merged as e898d49, so this one is closed.


Generated by Claude Code

@risu729 risu729 closed this Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant