Repository navigation
test: organize login badge cases without changing discovery - #1588
Merged
Merged
Conversation
Name the modules *-cases.ts, share their contexts through context.ts, place the registrar imports and fixture type with their peers, and describe the layout in the docs section. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011PUTx3w1HVYZp73fQasU3g
# Conflicts: # docs/development.md
# Conflicts: # docs/development.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #1581 and keeps its commits, plus review fixes.
Summary
apps/extension/src/login/badge.test.tskeeps the hoistedwxt/browsermock, the root timer hooks, the describe scopes, the shared fixtures and harness. Synchronous registrar modules inapps/extension/test/login/badge/hold the presentation, writes and navigation, persistence and page-status recording cases.badge.test.tsmax-lines exemption is removed from.oxlintrc.json(the entry is about 800 lines, the largest module about 400).Review fixes on top of #1581
*-cases.ts, sopresentation.tsno longer shares a name withsrc/diagnostics/presentation.ts.test/login/badge/context.tswith the four module contexts built fromBadgeTestFixtures, replacing the repeated 12- and 13-keyPicklists and theGeneration/reporttypes written in the status module.BadgeTestFixturessits right after the fixtures and harness, and the stray blank line in the imports is gone.badge.exhaustive.test.tsis a separate entry).Verification
src/login/badge.test.ts: 134, identical to main and all passing.oxfmt --check,oxlint apps/extension,rumdl check docs/development.md,mise run //apps/extension:typecheckpass.Generated by Claude Code