Skip to content

test: organize API owner cases without changing discovery - #1583

Closed
risu729 wants to merge 1 commit into
mainfrom
refactor/api-owner-tests-20261112
Closed

risu729 wants to merge 1 commit into
mainfrom
refactor/api-owner-tests-20261112

Conversation

@risu729

@risu729 risu729 commented Nov 12, 2026 •

Copy link
Copy Markdown
Owner

The API owner test entry exceeded the 1,000-line limit and mixed owner web UI, recipe management, and request-log cases. Keep the eight original describe scopes, root Access-key installation and shared fixtures in the entry; move the three coherent groups into passive synchronous registrars. Recipe and request-log helpers stay with all their uses and initialize at the same suite-registration point. The entry is 795 lines; modules are 182, 537, and 321 lines. Remove only its max-lines exemption and document the arrangement.

Independent source review of the final head found no issues. All three bodies match their originals byte-for-byte; reconstruction preserves the full executable AST, comments, raw templates, import owners and initialization/lifetime. Eight scopes comprise seven top-level suites and the nested vault-policy suite. The 46 declarations expand to 63 cases. All four TypeScript files remain byte-identical across the rebase.

Separate runtime verification injected original Git source at the identical module path: baseline 63/63 passed (11.94s), and the existing full API task with coverage passed 670/670 across 25 files (154.59s). All case IDs, full titles, order, results, suite IDs and explicit parents match. Discovery remains 25 entries; coverage contains 37 production files and no owner entry/helpers. API build, API/web typechecks, scoped checks and documentation validation pass.

The initial CI and CodeQL attempts stopped before test/analysis jobs began, with GitHub internal-server-error annotations. Both were retried once on the same head. Final CI attempt 2 passed Verify, Orders and components, all six browser shards and CI Check; CodeQL attempt 2 passed both analyses. No test or source adjustment was needed for that startup failure.

The actual tested merge tree equals the final head with the expected base. Every task count matches that base's CI: Verify 9,186 tests/274 files plus 73 tool tests, and components 1,814 tests/108 files. Observed timings: Verify 218→187s, runtime 169.78→150.19s, API 155.53→133.09s, owner entry 15.097→12.057s and components 217→147s; vault, i18n and connections tasks were slower. These single-run observations do not establish causal speedup or zero regression.

Part of the approved refactor scope. No production code, assertions, timeout, discovery, coverage or dependency changes. Access keys and databases are synthetic/local. No merge or auto-merge requested.

@risu729 risu729 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent source review of the final head: no actionable findings.

All three registrar bodies match their original describe bodies byte-for-byte, including helpers, comments, literals and raw templates. Expansion reproduces the describe ASTs and all other executable top-level nodes. There are eight scopes (seven top-level and the nested synced-vault-policy suite) and 46 declarations expanding to 63 cases: 44 plain, 15 rejected-token rows and four outage rows.

Moved imports retain original modules/symbols/type kinds. The root Access-key installation, shared function identity, suite-local initialization point and lifetime remain intact. Registrars are passive and synchronous; the entry reference is erased type-only. No changed this/arguments/new.target, hoisted mocks, hooks, snapshots, runtime cycle, discovery, coverage or task configuration. All four TypeScript blobs are byte-identical across the rebase, which only changes surrounding lint-list context. This was source review only; separate runtime verification and final CI remain distinct.

risu729 commented Nov 12, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #1590, which keeps this commit and adds the review fixes (*-cases.ts module names and a docs section of its own placed after the sibling sections). #1590 is merged as 6d5afb2, so this one is closed.


Generated by Claude Code

@risu729 risu729 closed this Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant