Repository navigation
test: organize API owner cases without changing discovery - #1590
Merged
Merged
Conversation
Name the modules *-cases.ts so they do not collide with the web and route files, and describe the layout in a docs section placed after the sibling sections. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011PUTx3w1HVYZp73fQasU3g
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011PUTx3w1HVYZp73fQasU3g
# Conflicts: # docs/development.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #1583 and keeps its commit, plus review fixes.
Summary
services/api/test/owner.test.tskeeps the synthetic Access keys, themanageApi,postPairandpairDevicehelpers and every describe scope. Synchronous registrar modules inservices/api/test/owner/hold the web UI, recipe and request-log cases.owner.test.tsmax-lines exemption is removed from.oxlintrc.json(the entry is 795 lines).Review fixes on top of #1583
web-ui-cases.ts,recipe-cases.tsandrequest-log-cases.ts, so they no longer share names withservices/api/web/recipes.tsx,web/request-log.tsxandsrc/routes/recipes.ts.dashboard.test.tsandpairing.test.tsalso hit/manageroutes), namesOwnerTestHelpersand theimport type, and says the missing.test.tssuffix is what keeps the modules out of thetest/**/*.test.tsinclude.Verification
test/owner.test.ts: 63, identical to main and all passing.oxfmt --check,oxlint services/api,rumdl check docs/development.md,mise run //services/api:typecheckpass.Generated by Claude Code