Skip to content

test: organize API owner cases without changing discovery - #1590

Merged
risu729 merged 5 commits into
mainfrom
claude/project-thread-ei232v
Nov 12, 2026
Merged

risu729 merged 5 commits into
mainfrom
claude/project-thread-ei232v

Conversation

@risu729

@risu729 risu729 commented Nov 12, 2026

Copy link
Copy Markdown
Owner

Replaces #1583 and keeps its commit, plus review fixes.

Summary

  • services/api/test/owner.test.ts keeps the synthetic Access keys, the manageApi, postPair and pairDevice helpers and every describe scope. Synchronous registrar modules in services/api/test/owner/ hold the web UI, recipe and request-log cases.
  • The owner.test.ts max-lines exemption is removed from .oxlintrc.json (the entry is 795 lines).

Review fixes on top of #1583

  • Renamed the modules to web-ui-cases.ts, recipe-cases.ts and request-log-cases.ts, so they no longer share names with services/api/web/recipes.tsx, web/request-log.tsx and src/routes/recipes.ts.
  • The docs section now sits after the sibling test organization sections and describes the layout rather than the change. It no longer calls this the sole owner entry (other discovered files such as dashboard.test.ts and pairing.test.ts also hit /manage routes), names OwnerTestHelpers and the import type, and says the missing .test.ts suffix is what keeps the modules out of the test/**/*.test.ts include.
  • Merged main; the docs conflict is resolved by keeping every main section and adding this one before "Login wire contracts".

Verification

  • Vitest JSON reporter test IDs for test/owner.test.ts: 63, identical to main and all passing.
  • Inlining the registrars back gives the main file, apart from the moved imports and the exported type.
  • oxfmt --check, oxlint services/api, rumdl check docs/development.md, mise run //services/api:typecheck pass.

Generated by Claude Code

risu729 and others added 5 commits November 12, 2026 22:36
Name the modules *-cases.ts so they do not collide with the web and
route files, and describe the layout in a docs section placed after
the sibling sections.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011PUTx3w1HVYZp73fQasU3g
@risu729 risu729 self-assigned this Nov 12, 2026
@risu729
risu729 merged commit 6d5afb2 into main Nov 12, 2026
14 checks passed
@risu729
risu729 deleted the claude/project-thread-ei232v branch November 12, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants