More thorough linting

[aniketEng]

Now linting against all warnings as well.

[mghibaudi]

Few questions - suggestions

[Copilot]

Pull request overview

This PR strengthens the repo’s Verilator lint flow by enabling -Wall and then updating RTL/testbench code, waivers, and lint stubs to reduce or waive newly surfaced warnings.

Changes:

• Enable Verilator -Wall linting and expand/update lint_waivers.vlt accordingly.
• Remove wildcard package imports and use explicit qeciphy_pkg::... qualification to satisfy lint and avoid namespace leakage.
• Improve lintability of GT/MMCM stub modules (drive outputs) and adjust reset/CDC helper(s) to support configurable reset style.

Reviewed changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
uvm/qeciphy_env/scoreboards/qeciphy_env_state_scoreboard.svh	Adds/reset-tracking logic for PHY reset-state checking in the UVM scoreboard.
src/qeciphy_tx_packet_gen.sv	Switches to explicit qeciphy_pkg:: qualification and minor formatting changes for lint.
src/qeciphy_serdes.sv	Types GT_TYPE parameter as string for cleaner lint/type checking.
src/qeciphy_rx_monitor.sv	Removes wildcard package import and qualifies package types/functions.
src/qeciphy_rx_controller.sv	Removes wildcard package import; qualifies enum/constants from qeciphy_pkg.
src/qeciphy_rx_comma_detect.sv	Removes unused local signals flagged by lint.
src/qeciphy_rx_boundary_gen.sv	Removes wildcard package import; qualifies is_faw reference.
src/qeciphy_rx_32b_to_64b.sv	Removes wildcard package import; qualifies is_faw reference.
src/qeciphy_resetcontroller.sv	Renames/reset-interfaces to reflect async master reset and adds an AXIS-domain reset output.
src/qeciphy_gt_wrapper.sv	Refactors comma-detect enable logic scoping; tweaks GTX reset hookup for lint/behavior.
src/qeciphy_error_handler.sv	Removes wildcard package import; qualifies enum/constants and casts.
src/qeciphy_crc_check.sv	Removes wildcard package import; qualifies types and adjusts reset style for one register.
src/qeciphy_controller.sv	Removes wildcard package import; qualifies status enum/constants.
src/QECIPHY.sv	Removes wildcard build-cfg import; wires synchronized AXIS reset and qualifies build config constant.
lint_waivers.vlt	Adds/organizes waivers needed under -Wall and clarifies intent with comments.
lint_stubs/qeciphy_gty_transceiver.sv	Drives previously undriven outputs to eliminate lint warnings.
lint_stubs/qeciphy_gtx_transceiver.sv	Adds explicit port typing and drives outputs to eliminate lint warnings.
lint_stubs/qeciphy_gth_transceiver.sv	Drives previously undriven outputs to eliminate lint warnings.
lint_stubs/qeciphy_clk_mmcm.sv	Drives outputs to eliminate lint warnings.
lint_stubs/GTXE2_COMMON.sv	Drives outputs to eliminate lint warnings.
lint_stubs/BUFG_GT.sv	Drives output to eliminate lint warnings.
lib/riv_synchronizer_2ff/src/riv_synchronizer_2ff.sv	Adds configurable reset style to the 2FF synchronizer.
Makefile	Updates lint target to run Verilator with -Wall and apply waivers earlier in the command line.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[mghibaudi]

Looks good to me now - thanks