fix: use boolValue for hasPressListener prop#3872
Conversation
|
Apologies. This looks like a duplicate of #3865. My search skills failed me. I'll leave this open for the maintainers to decide how to proceed. |
|
Hi @chrisforerunner, thank you for this contribution! 🎉 This fix looks great and follows the same pattern as #3850. The explicit I can see you've:
This should indeed fix #3864 where The CI is currently not running on this PR. Could you please rebase your branch onto the latest main? This will allow the CI checks to run: git fetch upstream main
git rebase upstream/main
git push --force-with-lease origin your-branch-nameThank you again for catching and fixing this New Architecture compatibility issue! The change looks ready to merge once CI passes. |
|
Closed by #3865 |
Description
Explicitly extracts the
boolValuefrom thehasPressListenerprop onRNMBXVectorSourceComponentView. This fixes an issue when running in New Architecture where allVectorSourcelayers are marked astouchablebecausehasPressListeneris alwaystruewhen bridged to Swift.Functionally, this manifests as a bug wherein
VectorSourcecomponents will incorrectly "capture" taps, even when noonPresshandler is provided, also preventing the rootMapView:onPresshandler from firing.Similar change as #3850. Fixes #3864.
Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)