Skip to content

fix: use boolValue for hasPressListener prop #3872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chrisforerunner wants to merge 1 commit into from
Closed

fix: use boolValue for hasPressListener prop #3872

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ios/RNMBX/RNMBXVectorSourceComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ - (instancetype)initWithFrame:(CGRect)frame
- (void)prepareView
{
_view = [[RNMBXVectorSource alloc] init];

// capture weak self reference to prevent retain cycle
__weak __typeof__(self) weakSelf = self;

Expand Down Expand Up @@ -124,13 +124,13 @@ - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &
}
id hasPressListener = RNMBXConvertFollyDynamicToId(newProps.hasPressListener);
if (hasPressListener != nil) {
_view.hasPressListener = hasPressListener;
_view.hasPressListener = [hasPressListener boolValue];
}
id hitbox = RNMBXConvertFollyDynamicToId(newProps.hitbox);
if (hitbox != nil) {
_view.hitbox = hitbox;
}

[super updateProps:props oldProps:oldProps];
}

Expand Down
Loading