Skip to content

Onboard repo with workspace standards#166

Merged
rolker merged 2 commits into
jazzyfrom
feature/issue-165
Jul 15, 2026
Merged

Onboard repo with workspace standards#166
rolker merged 2 commits into
jazzyfrom
feature/issue-165

Conversation

@rolker

@rolker rolker commented Jul 14, 2026

Copy link
Copy Markdown
Owner

Summary

Add workspace-standard infrastructure (onboarding campaign rolker/unh_marine_autonomy#264, tier-1 repo 2/4):

  • Pre-commit config — workspace template; protected branch jazzy; Python lint hooks left out (the only .py file is a launch file). Repo has no ament linters wired, so no CI linter exclusion is needed (unlike unh_marine_navigation).
  • CI workflowros:jazzy-ros-core container, colcon build --packages-up-to camp + gtest suite. Four source-sibling repos cloned (unh_marine_autonomy, marine_colormap, unh_marine_navigation, marine_ais — the full first-party dependency closure traced from package.xml); everything else resolves via rosdep. The gtest suite forces QT_QPA_PLATFORM=offscreen internally, so it runs headless.
  • Root AGENTS.md — ADR-0017 pattern; Review Context flags operator-station safety framing, the three build targets, resource-lifecycle risk areas, and headless-test requirements.
  • Agent guide touch-up.agents/README.md no longer claims the repo has no CI/pre-commit.

Done via API (no file change): git-bug GitHub bridge.
Deferred to a follow-up issue: license headers (BSD in package.xml, sources have none).

Closes #165


Authored-By: Claude Code Agent
Model: Claude Fable 5

Onboarding: pre-commit config, CI workflow (colcon build + headless gtest
suite with 4 source-sibling clones), root AGENTS.md (ADR-0017), and agent
guide update to reflect the new CI/pre-commit gates.

Closes #165
Copilot AI review requested due to automatic review settings July 14, 2026 20:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds “workspace-standard” repo infrastructure so camp matches the ROS 2 Agent Workspace onboarding baseline (agent guidance, pre-commit hooks, and CI for build + gtest on the jazzy branch).

Changes:

  • Add root AGENTS.md with repo-specific review context and safety framing for an operator-station GUI.
  • Add .pre-commit-config.yaml with workspace-template hooks (YAML/XML checks, cmake-lint, yamllint, branch protection).
  • Add GitHub Actions CI workflow building/testing in a ros:jazzy-ros-core container and update .agents/README.md to reflect CI/pre-commit availability.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
AGENTS.md Adds repo-specific agent/review guidance and safety context for CAMP.
.pre-commit-config.yaml Introduces workspace-template pre-commit hooks and protects jazzy.
.github/workflows/ci.yml Adds containerized CI for colcon build + gtest with source-sibling deps cloned.
.agents/README.md Updates agent guide to reflect new CI and pre-commit configuration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci.yml
Comment on lines +74 to +76
run: >
DEBIAN_FRONTEND=noninteractive
rosdep install --from-paths src --ignore-src -r -y
Copilot AI review requested due to automatic review settings July 14, 2026 20:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comment thread .github/workflows/ci.yml
Comment on lines +24 to +28
- name: Install ros dev tools
run: DEBIAN_FRONTEND=noninteractive apt-get -y install ros-dev-tools

- name: Checkout
uses: actions/checkout@v6
@rolker

rolker commented Jul 15, 2026

Copy link
Copy Markdown
Owner Author

Review triage — Copilot findings

Both findings are refuted by the green CI run on this PR (run 29365305503) and match the template false positives documented in the onboarding-campaign notes (rolker/unh_marine_autonomy#264, nav session):

  1. rosdep install missing --rosdistro / ROS_DISTRO unset — the official ros:jazzy-ros-core image sets ENV ROS_DISTRO=jazzy in its Dockerfile; Docker ENV applies to every process in the container independent of the entrypoint. The "Install ROS dependencies" step passed as-is.
  2. git not present in the container — the "Install ros dev tools" step (ros-dev-tools) installs git before checkout; the checkout and all four sibling clones succeeded.

No changes needed.


Authored-By: Claude Code Agent
Model: Claude Fable 5

@rolker rolker merged commit 82df44a into jazzy Jul 15, 2026
2 checks passed
@rolker rolker deleted the feature/issue-165 branch July 15, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Onboard repo with workspace standards

2 participants