Onboard repo with workspace standards#166
Merged
Merged
Conversation
Onboarding: pre-commit config, CI workflow (colcon build + headless gtest suite with 4 source-sibling clones), root AGENTS.md (ADR-0017), and agent guide update to reflect the new CI/pre-commit gates. Closes #165
There was a problem hiding this comment.
Pull request overview
Adds “workspace-standard” repo infrastructure so camp matches the ROS 2 Agent Workspace onboarding baseline (agent guidance, pre-commit hooks, and CI for build + gtest on the jazzy branch).
Changes:
- Add root
AGENTS.mdwith repo-specific review context and safety framing for an operator-station GUI. - Add
.pre-commit-config.yamlwith workspace-template hooks (YAML/XML checks, cmake-lint, yamllint, branch protection). - Add GitHub Actions CI workflow building/testing in a
ros:jazzy-ros-corecontainer and update.agents/README.mdto reflect CI/pre-commit availability.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
AGENTS.md |
Adds repo-specific agent/review guidance and safety context for CAMP. |
.pre-commit-config.yaml |
Introduces workspace-template pre-commit hooks and protects jazzy. |
.github/workflows/ci.yml |
Adds containerized CI for colcon build + gtest with source-sibling deps cloned. |
.agents/README.md |
Updates agent guide to reflect new CI and pre-commit configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+74
to
+76
| run: > | ||
| DEBIAN_FRONTEND=noninteractive | ||
| rosdep install --from-paths src --ignore-src -r -y |
Comment on lines
+24
to
+28
| - name: Install ros dev tools | ||
| run: DEBIAN_FRONTEND=noninteractive apt-get -y install ros-dev-tools | ||
|
|
||
| - name: Checkout | ||
| uses: actions/checkout@v6 |
Owner
Author
Review triage — Copilot findingsBoth findings are refuted by the green CI run on this PR (run 29365305503) and match the template false positives documented in the onboarding-campaign notes (rolker/unh_marine_autonomy#264, nav session):
No changes needed. Authored-By: |
This was referenced Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add workspace-standard infrastructure (onboarding campaign rolker/unh_marine_autonomy#264, tier-1 repo 2/4):
jazzy; Python lint hooks left out (the only.pyfile is a launch file). Repo has no ament linters wired, so no CI linter exclusion is needed (unlike unh_marine_navigation).ros:jazzy-ros-corecontainer,colcon build --packages-up-to camp+ gtest suite. Four source-sibling repos cloned (unh_marine_autonomy, marine_colormap, unh_marine_navigation, marine_ais — the full first-party dependency closure traced frompackage.xml); everything else resolves via rosdep. The gtest suite forcesQT_QPA_PLATFORM=offscreeninternally, so it runs headless.AGENTS.md— ADR-0017 pattern; Review Context flags operator-station safety framing, the three build targets, resource-lifecycle risk areas, and headless-test requirements..agents/README.mdno longer claims the repo has no CI/pre-commit.Done via API (no file change): git-bug GitHub bridge.
Deferred to a follow-up issue: license headers (BSD in
package.xml, sources have none).Closes #165
Authored-By:
Claude Code AgentModel:
Claude Fable 5