Export datum_config target for downstream linkage (#28)#29
Merged
Conversation
resolve_datum/load_datum_config live in the datum_config library, which was
installed bare (not in the export set) — find_package(mru_transform) yielded no
linkable imported target. Add datum_config to export_${PROJECT_NAME} and export
the transitive yaml-cpp dependency so cube_bathymetry's chart-prior importer
(rolker/unh_marine_autonomy#163) can reuse the datum core.
Pure packaging change; no source change. Verified: install now emits
mru_transform::datum_config + yaml-cpp in exported deps.
Closes #28
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Export the
datum_configlibrary target so downstream packages can linkresolve_datum/load_datum_configviafind_package(mru_transform).datum_configwas installed bare (install(TARGETS datum_config LIBRARY DESTINATION lib)) — not in theexport_${PROJECT_NAME}set — so a consumer gotthe installed header +
.soon disk but no linkable imported target. Thismoves it into the existing package export set and exports the transitive
yaml-cppdependency.Pure packaging/export change — no source change,
test_datum_configunaffected.Closes #28.
Why now
The Chart-prior importer (rolker/cube_bathymetry#44, A2 of
rolker/unh_marine_autonomy#163) calls
resolve_datum/load_datum_configfromcube_bathymetryto convert the contour prior to ellipsoidal Chart tiles —reusing this datum core rather than duplicating the polygon/precedence logic.
Verification
colcon buildclean (the only stderr is pre-existing geodesy-Wparentheses/unused-param warnings, unrelated).
ament_lint_cmake: No problems found.export_mru_transformExport.cmake:add_library(mru_transform::datum_config SHARED IMPORTED)ament_cmake_export_dependencies-extras.cmake:…;tf2_ros;yaml-cppAuthored-By:
Claude Code AgentModel:
Claude Opus 4.8 (1M context)