Conversation
Member
|
Hello, thanks for the pl, but could you add comment with /cla-sign? |
Member
|
Also please, do the pl to the release/2.3 branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #92.
The bulk resolve action used the translated action name as an identifier, and that value ends up in the API path:
With a non-English UI this produced requests like
POST /api/alerts/7/закрыть, which 404. It worked in English only because the English translation ofalert_details.bulk.resolve_actionhappens to be the stringresolve.This replaces the translation with the literal
"resolve"in the three places where the value is used as an identifier, matching how"ack"is already handled:alerts.js:144— the filter that decides which selected groups are eligiblealerts.js:259— the selected-count shown on the buttonalerts.js:3191— the call that triggers the bulk actionChanging only the call site would not be enough: the filter at line 144 compares against the same translated value, so it would stop matching and the button would report an empty selection instead.
alerts.js:3233still usesi18n.t("alert_details.bulk.resolve_action")to build the human-readable label, which is the correct use of the translation and is left unchanged.Verified against the Russian locale, where the bulk resolve button now sends
POST /api/alerts/{id}/resolve.