Skip to content

Use the literal resolve action instead of its translation in bulk alert actions #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lavr wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Use the literal resolve action instead of its translation in bulk alert actions #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/static/js/pages/alerts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ function selectedAlertGroupsForBulkAction(action) {
return status === "firing";
}

if (action === i18n.t("alert_details.bulk.resolve_action")) {
if (action === "resolve") {
return status !== "resolved" && status !== "merged";
}

Expand Down Expand Up @@ -256,7 +256,7 @@ function renderAlertsBulkActions() {
const bar = ensureAlertsBulkActionsBar();
const count = selectedAlertGroupIds.size;
const ackCount = selectedAlertGroupsForBulkAction("ack").length;
const resolveCount = selectedAlertGroupsForBulkAction(i18n.t("alert_details.bulk.resolve_action")).length;
const resolveCount = selectedAlertGroupsForBulkAction("resolve").length;

bar.toggle(count > 0);
bar.find("#alerts-bulk-selected-count").text(i18n.t("alerts.bulk.selected", {count: count}));
Expand Down Expand Up @@ -3188,7 +3188,7 @@ $(document).on("click", "#alerts-ack-selected", function () {
});

$(document).on("click", "#alerts-resolve-selected", function () {
bulkUpdateSelectedAlertGroups(i18n.t("alert_details.bulk.resolve_action"));
bulkUpdateSelectedAlertGroups("resolve");
});

$(document).on("click", "#alerts-merge-selected", function () {
Expand Down
Loading