Skip to content

fix(submissions): keep a row's action buttons on one line - #2051

Merged
rpgmem merged 3 commits into
developfrom
claude/submissions-actions-width
Oct 24, 2026
Merged

rpgmem merged 3 commits into
developfrom
claude/submissions-actions-width

Conversation

@rpgmem

@rpgmem rpgmem commented Oct 24, 2026

Copy link
Copy Markdown
Owner

Closes #2050.

Problem

On Certificates → Submissions, a row's Edit, PDF and Trash buttons broke onto two lines although Status and Date sat half empty. The table is table-layout: fixed and only ID has a width, so every column got an equal share. Measured in a 1700 px table: Actions 228 px, while the three buttons need 236 px plus gaps and padding. Trash also had no gap before it, because the buttons were separated by text spaces and one space was missing.

Change

Measured (Chromium render of the row with the plugin's sheets)

Table width Actions Three buttons (published) Four buttons (trashed)
1700 px 307 px one line two lines
1366 px 307 px one line two lines
1180 px 307 px one line two lines

Before: Actions 228 px and two lines at 1700 px. The text columns (Form, E-mail, Data) share what is left.

Tests

  • SubmissionsListTest: the actions cell is one ffc-submission-actions container (60 tests pass).
  • Guards: class emission, stylesheet ownership, namespace anchor, spacing and colour tokens, class naming, utility scope (120 tests). PHPCS, PHPStan and Stylelint are clean. The full PHPUnit suite runs in CI.

Risk

  • Layout only, on one screen. A very long date format or a long translated status label wraps inside its own cell rather than widening it.

Checklist

Waits as a draft until #2049 merges (one PR armed at a time).


Generated by Claude Code

The fixed-layout table gave every column but ID an equal share, so the
Actions column (228 px in a 1700 px table) was narrower than Edit, PDF and
Trash need, while Status and Date sat half empty. Status and Date now take
9em, Actions 22em, and the buttons sit in a flex row with an even gap; a
trashed row's four buttons still wrap. Measured by a render at 1700, 1366
and 1180 px.

Closes #2050

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018srx5hc431EYmG4MHUr2KA
@rpgmem rpgmem added bug Something isn't working area:certificates labels Oct 24, 2026 — with Claude
On the submissions screen the paragraph followed the status links and the
search box, which WordPress floats left and right, and ran into the gap
between them. It now carries ffc-pii-reveal-bar, which clears both; on the
screens without floats it changes nothing.

Refs #2050

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018srx5hc431EYmG4MHUr2KA

rpgmem commented Oct 24, 2026

Copy link
Copy Markdown
Owner Author

Added to this PR, same screen: "Reveal this page" sat between the status links and the search box.

PiiReveal::page_button() printed a plain <p> right after $table->views() (floated left) and search_box() (floated right), so the paragraph flowed into the gap between them. The paragraph now carries ffc-pii-reveal-bar, which ffc-admin-components.css gives clear: both. On the other screens that draw it (appointments, audience members, date messages) nothing floats before it, so it changes nothing there.

Measured in Chromium with the two floats: before, the button's top was at 8 px and its left at 222 px, beside the floats; after, at 34 px (the floats' bottom) and 8 px. PiiRevealTest pins the class; the appointments, audience and date-messages view tests and the CSS guards pass (170 tests).


Generated by Claude Code

@rpgmem
rpgmem marked this pull request as ready for review October 24, 2026 11:14
@rpgmem
rpgmem enabled auto-merge (squash) October 24, 2026 11:14
@rpgmem
rpgmem merged commit 1d2574e into develop Oct 24, 2026
21 checks passed
@rpgmem
rpgmem deleted the claude/submissions-actions-width branch October 24, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:certificates bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants