compiletest: Don't assume `aux-crate` becomes a `*.so` with `no-prefer-dynamic` #151691

Enselic · 2026-01-26T15:19:06Z

Since it does not make sense to do so. If someone prefers no dynamic stuff, the last thing they want to look for is an .so file. Also add a regression test. Without the fix, the test fails with:

error: test compilation failed although it shouldn't!
--- stderr -------------------------------
error: extern location for no_prefer_dynamic_lib does not exist: .../auxiliary/libno_prefer_dynamic_lib.so
  --> .../no-prefer-dynamic-means-no-so.rs:9:5
   |
LL |     no_prefer_dynamic_lib::return_42();
   |     ^^^^^^^^^^^^^^^^^^^^^

Needed by:

Replace -Zon-broken-pipe=... with Externally Implementable Item #[std::io::on_broken_pipe] #150591 because of Externally Implementable Items: error: undefined symbol with dynamic linking #151271. But IMHO this PR makes sense on its own.

Must wait for:

compiletest: Support --extern modifiers with proc-macro directive #151695

@Zalathar

…thar compiletest: Support `--extern` modifiers with `proc-macro` directive So that the `src/tools/compiletest/src/directives/auxiliary/tests.rs` test does not have to (ab)use the `aux-crate` directive for this purpose. This is very edge-casey so I don't think we should document this in rustc-dev-guide. Mentioning it will confuse more than it helps. If someone needs to do this they will look at the code and easily find the functionality. This is a bit hacky since `--extern priv:pm.rs` is not valid, but we can make our directives work however we want. And I think this is a fine pragmatic approach. Doing it "the right way" would be a lot of work for not much gain. Plus, that work can be done incrementally in small steps in the future if wanted. r? @Zalathar --- Follow-up to: - rust-lang#151353 - rust-lang#151670 ### Unblocks: - rust-lang#151691, because without this fix that test fails (see rust-lang#151691 (comment))

@Zalathar

…thar compiletest: Support `--extern` modifiers with `proc-macro` directive So that the `src/tools/compiletest/src/directives/auxiliary/tests.rs` test does not have to (ab)use the `aux-crate` directive for this purpose. This is very edge-casey so I don't think we should document this in rustc-dev-guide. Mentioning it will confuse more than it helps. If someone needs to do this they will look at the code and easily find the functionality. This is a bit hacky since `--extern priv:pm.rs` is not valid, but we can make our directives work however we want. And I think this is a fine pragmatic approach. Doing it "the right way" would be a lot of work for not much gain. Plus, that work can be done incrementally in small steps in the future if wanted. r? @Zalathar --- Follow-up to: - rust-lang#151353 - rust-lang#151670 ### Unblocks: - rust-lang#151691, because without this fix that test fails (see rust-lang#151691 (comment))

@Zalathar

…thar compiletest: Support `--extern` modifiers with `proc-macro` directive So that the `src/tools/compiletest/src/directives/auxiliary/tests.rs` test does not have to (ab)use the `aux-crate` directive for this purpose. This is very edge-casey so I don't think we should document this in rustc-dev-guide. Mentioning it will confuse more than it helps. If someone needs to do this they will look at the code and easily find the functionality. This is a bit hacky since `--extern priv:pm.rs` is not valid, but we can make our directives work however we want. And I think this is a fine pragmatic approach. Doing it "the right way" would be a lot of work for not much gain. Plus, that work can be done incrementally in small steps in the future if wanted. r? @Zalathar --- Follow-up to: - rust-lang#151353 - rust-lang#151670 ### Unblocks: - rust-lang#151691, because without this fix that test fails (see rust-lang#151691 (comment))

@Zalathar

Rollup merge of #151695 - Enselic:proc-macro-priv-v2, r=Zalathar compiletest: Support `--extern` modifiers with `proc-macro` directive So that the `src/tools/compiletest/src/directives/auxiliary/tests.rs` test does not have to (ab)use the `aux-crate` directive for this purpose. This is very edge-casey so I don't think we should document this in rustc-dev-guide. Mentioning it will confuse more than it helps. If someone needs to do this they will look at the code and easily find the functionality. This is a bit hacky since `--extern priv:pm.rs` is not valid, but we can make our directives work however we want. And I think this is a fine pragmatic approach. Doing it "the right way" would be a lot of work for not much gain. Plus, that work can be done incrementally in small steps in the future if wanted. r? @Zalathar --- Follow-up to: - #151353 - #151670 ### Unblocks: - #151691, because without this fix that test fails (see #151691 (comment))

…r-dynamic` Since it does not make sense to do so. If someone prefers no dynamic stuff, the last thing they want to look for is an `.so` file. Also add a regression test. Without the fix, the test fails with: error: test compilation failed although it shouldn't! --- stderr ------------------------------- error: extern location for no_prefer_dynamic_lib does not exist: .../auxiliary/libno_prefer_dynamic_lib.so --> .../no-prefer-dynamic-means-no-so.rs:9:5 | LL | no_prefer_dynamic_lib::return_42(); | ^^^^^^^^^^^^^^^^^^^^^

Enselic · 2026-02-03T06:40:13Z

Ready for review.

rustbot · 2026-02-03T06:40:18Z

Some changes occurred in src/tools/compiletest

cc @jieyouxu

rustbot · 2026-02-03T06:40:20Z

r? @jdonszelmann

rustbot has assigned @jdonszelmann.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

jdonszelmann · 2026-02-03T08:17:29Z

@bors r+ rollup

rust-bors · 2026-02-03T08:17:34Z

📌 Commit f14e3ee has been approved by jdonszelmann

It is now in the queue for this repository.

…mic-v2, r=jdonszelmann compiletest: Don't assume `aux-crate` becomes a `*.so` with `no-prefer-dynamic` Since it does not make sense to do so. If someone prefers no dynamic stuff, the last thing they want to look for is an .so file. Also add a regression test. Without the fix, the test fails with: error: test compilation failed although it shouldn't! --- stderr ------------------------------- error: extern location for no_prefer_dynamic_lib does not exist: .../auxiliary/libno_prefer_dynamic_lib.so --> .../no-prefer-dynamic-means-no-so.rs:9:5 | LL | no_prefer_dynamic_lib::return_42(); | ^^^^^^^^^^^^^^^^^^^^^ ### Needed by: - rust-lang#150591 because of rust-lang#151271. But IMHO this PR makes sense on its own. ### Must wait for: - [x] rust-lang#151695

Rollup of 6 pull requests Successful merges: - #152008 (`rust-analyzer` subtree update) - #151109 (fN::BITS constants for feature float_bits_const) - #151976 (Rename `collect_active_jobs` to several distinct names) - #151691 (compiletest: Don't assume `aux-crate` becomes a `*.so` with `no-prefer-dynamic`) - #151919 (fix: Make `--color always` always print color with `--explain`) - #152028 (Convert to inline diagnostics in `rustc_driver_impl`)

Rollup of 7 pull requests Successful merges: - #152008 (`rust-analyzer` subtree update) - #151109 (fN::BITS constants for feature float_bits_const) - #151976 (Rename `collect_active_jobs` to several distinct names) - #151691 (compiletest: Don't assume `aux-crate` becomes a `*.so` with `no-prefer-dynamic`) - #151919 (fix: Make `--color always` always print color with `--explain`) - #152017 (Remove `with_no_trimmed_paths` use in query macro) - #152028 (Convert to inline diagnostics in `rustc_driver_impl`)

Rollup merge of #151691 - Enselic:dylib-only-for-prefer-dynamic-v2, r=jdonszelmann compiletest: Don't assume `aux-crate` becomes a `*.so` with `no-prefer-dynamic` Since it does not make sense to do so. If someone prefers no dynamic stuff, the last thing they want to look for is an .so file. Also add a regression test. Without the fix, the test fails with: error: test compilation failed although it shouldn't! --- stderr ------------------------------- error: extern location for no_prefer_dynamic_lib does not exist: .../auxiliary/libno_prefer_dynamic_lib.so --> .../no-prefer-dynamic-means-no-so.rs:9:5 | LL | no_prefer_dynamic_lib::return_42(); | ^^^^^^^^^^^^^^^^^^^^^ ### Needed by: - #150591 because of #151271. But IMHO this PR makes sense on its own. ### Must wait for: - [x] #151695

This was referenced Jan 26, 2026

compiletest: Don't look for Dylib if no-prefer-dynamic #151257

Closed

compiletest: Support --extern modifiers with proc-macro directive #151695

Merged

This comment has been minimized.

Sign in to view

Enselic force-pushed the dylib-only-for-prefer-dynamic-v2 branch from 74f2d21 to 50622c9 Compare February 3, 2026 05:00

Enselic force-pushed the dylib-only-for-prefer-dynamic-v2 branch from 50622c9 to f14e3ee Compare February 3, 2026 05:00

Enselic changed the title ~~compiletest: Don't look for aux-crate .so if //@ no-prefer-dynamic~~ compiletest: Don't assume aux-crate becomes a *.so with no-prefer-dynamic Feb 3, 2026

Enselic marked this pull request as ready for review February 3, 2026 06:40

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 3, 2026

rustbot assigned jdonszelmann Feb 3, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 3, 2026

jhpratt mentioned this pull request Feb 3, 2026

Rollup of 3 pull requests #152031

Closed

jhpratt mentioned this pull request Feb 3, 2026

Rollup of 6 pull requests #152032

Closed

Zalathar mentioned this pull request Feb 3, 2026

Rollup of 7 pull requests #152035

Merged

rust-bors bot merged commit 6d064d9 into rust-lang:main Feb 3, 2026
11 checks passed

rustbot added this to the 1.95.0 milestone Feb 3, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

compiletest: Don't assume `aux-crate` becomes a `*.so` with `no-prefer-dynamic` #151691

compiletest: Don't assume `aux-crate` becomes a `*.so` with `no-prefer-dynamic` #151691

Enselic commented Jan 26, 2026 •

edited

Loading

Uh oh!

This comment has been minimized.

Enselic commented Feb 3, 2026

Uh oh!

rustbot commented Feb 3, 2026

Uh oh!

rustbot commented Feb 3, 2026

Uh oh!

jdonszelmann commented Feb 3, 2026

Uh oh!

rust-bors bot commented Feb 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

compiletest: Don't assume aux-crate becomes a *.so with no-prefer-dynamic #151691

compiletest: Don't assume aux-crate becomes a *.so with no-prefer-dynamic #151691

Conversation

Enselic commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Needed by:

Must wait for:

Uh oh!

This comment has been minimized.

Enselic commented Feb 3, 2026

Uh oh!

rustbot commented Feb 3, 2026

Uh oh!

rustbot commented Feb 3, 2026

Uh oh!

jdonszelmann commented Feb 3, 2026

Uh oh!

rust-bors bot commented Feb 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

compiletest: Don't assume `aux-crate` becomes a `*.so` with `no-prefer-dynamic` #151691

compiletest: Don't assume `aux-crate` becomes a `*.so` with `no-prefer-dynamic` #151691

Enselic commented Jan 26, 2026 •

edited

Loading