compiletest: Support `--extern` modifiers with `proc-macro` directive #151695

Enselic · 2026-01-26T15:34:49Z

So that the src/tools/compiletest/src/directives/auxiliary/tests.rs test does not have to (ab)use the aux-crate directive for this purpose.

This is very edge-casey so I don't think we should document this in rustc-dev-guide. Mentioning it will confuse more than it helps. If someone needs to do this they will look at the code and easily find the functionality.

This is a bit hacky since --extern priv:pm.rs is not valid, but we can make our directives work however we want. And I think this is a fine pragmatic approach. Doing it "the right way" would be a lot of work for not much gain. Plus, that work can be done incrementally in small steps in the future if wanted.

r? @Zalathar

Follow-up to:

Unblocks:

compiletest: Don't assume aux-crate becomes a *.so with no-prefer-dynamic #151691, because without this fix that test fails (see compiletest: Don't assume aux-crate becomes a *.so with no-prefer-dynamic #151691 (comment))

So that `pub-priv1.rs` test does not have to (ab)use the `aux-crate` directive for this purpose. This is very edge-casey so I don't think we should document this in rustc-dev-guide. If someone needs to do this they will look at the code and easily find the functionality. This is a bit hacky since `--extern priv:pm.rs` is not valid, but we can make our directives work however we want. And I think this is a fine pragmatic approach. Doing it "the right way" would be a lot of work for not much gain. Plus, that work can be done incrementally in small steps in the future if wanted.

rustbot · 2026-01-26T17:06:10Z

Some changes occurred in src/tools/compiletest

cc @jieyouxu

Zalathar · 2026-02-02T08:27:00Z

Thanks for splitting out the previous changes.

@bors r+

rust-bors · 2026-02-02T08:27:05Z

📌 Commit 996d72b has been approved by Zalathar

It is now in the queue for this repository.

@Zalathar

…thar compiletest: Support `--extern` modifiers with `proc-macro` directive So that the `src/tools/compiletest/src/directives/auxiliary/tests.rs` test does not have to (ab)use the `aux-crate` directive for this purpose. This is very edge-casey so I don't think we should document this in rustc-dev-guide. Mentioning it will confuse more than it helps. If someone needs to do this they will look at the code and easily find the functionality. This is a bit hacky since `--extern priv:pm.rs` is not valid, but we can make our directives work however we want. And I think this is a fine pragmatic approach. Doing it "the right way" would be a lot of work for not much gain. Plus, that work can be done incrementally in small steps in the future if wanted. r? @Zalathar --- Follow-up to: - rust-lang#151353 - rust-lang#151670 ### Unblocks: - rust-lang#151691, because without this fix that test fails (see rust-lang#151691 (comment))

…uwer Rollup of 11 pull requests Successful merges: - #150992 (link modifier `export-symbols`: export all global symbols from selected uptream c static libraries) - #151695 (compiletest: Support `--extern` modifiers with `proc-macro` directive) - #151938 (Use `#![feature(adt_const_params)]` for static query flags) - #151172 (Use default field values in a few more cases) - #151825 (more float constants) - #151870 (regression test for alias-relate changes in lub) - #151902 (explain why we dont skip some of this work when there are field projections) - #151974 (Update documentation for `Result::ok()`) - #151978 (Query cleanups) - #151979 (Fix uninitialized UEFI globals in tests) - #151992 (Port `#[rustc_hidden_type_of_opaque]` to attribute parser)

@Zalathar

…thar compiletest: Support `--extern` modifiers with `proc-macro` directive So that the `src/tools/compiletest/src/directives/auxiliary/tests.rs` test does not have to (ab)use the `aux-crate` directive for this purpose. This is very edge-casey so I don't think we should document this in rustc-dev-guide. Mentioning it will confuse more than it helps. If someone needs to do this they will look at the code and easily find the functionality. This is a bit hacky since `--extern priv:pm.rs` is not valid, but we can make our directives work however we want. And I think this is a fine pragmatic approach. Doing it "the right way" would be a lot of work for not much gain. Plus, that work can be done incrementally in small steps in the future if wanted. r? @Zalathar --- Follow-up to: - rust-lang#151353 - rust-lang#151670 ### Unblocks: - rust-lang#151691, because without this fix that test fails (see rust-lang#151691 (comment))

…uwer Rollup of 12 pull requests Successful merges: - #149596 (resolve: Report more visibility-related early resolution ambiguities for imports) - #151695 (compiletest: Support `--extern` modifiers with `proc-macro` directive) - #151938 (Use `#![feature(adt_const_params)]` for static query flags) - #151172 (Use default field values in a few more cases) - #151825 (more float constants) - #151870 (regression test for alias-relate changes in lub) - #151872 (Add inline syntax for diagnostic messages) - #151902 (explain why we dont skip some of this work when there are field projections) - #151909 (Skip overlapping spans in argument error suggestions) - #151978 (Query cleanups) - #151979 (Fix uninitialized UEFI globals in tests) - #151992 (Port `#[rustc_hidden_type_of_opaque]` to attribute parser)

@Zalathar

Rollup merge of #151695 - Enselic:proc-macro-priv-v2, r=Zalathar compiletest: Support `--extern` modifiers with `proc-macro` directive So that the `src/tools/compiletest/src/directives/auxiliary/tests.rs` test does not have to (ab)use the `aux-crate` directive for this purpose. This is very edge-casey so I don't think we should document this in rustc-dev-guide. Mentioning it will confuse more than it helps. If someone needs to do this they will look at the code and easily find the functionality. This is a bit hacky since `--extern priv:pm.rs` is not valid, but we can make our directives work however we want. And I think this is a fine pragmatic approach. Doing it "the right way" would be a lot of work for not much gain. Plus, that work can be done incrementally in small steps in the future if wanted. r? @Zalathar --- Follow-up to: - #151353 - #151670 ### Unblocks: - #151691, because without this fix that test fails (see #151691 (comment))

…mic-v2, r=jdonszelmann compiletest: Don't assume `aux-crate` becomes a `*.so` with `no-prefer-dynamic` Since it does not make sense to do so. If someone prefers no dynamic stuff, the last thing they want to look for is an .so file. Also add a regression test. Without the fix, the test fails with: error: test compilation failed although it shouldn't! --- stderr ------------------------------- error: extern location for no_prefer_dynamic_lib does not exist: .../auxiliary/libno_prefer_dynamic_lib.so --> .../no-prefer-dynamic-means-no-so.rs:9:5 | LL | no_prefer_dynamic_lib::return_42(); | ^^^^^^^^^^^^^^^^^^^^^ ### Needed by: - rust-lang#150591 because of rust-lang#151271. But IMHO this PR makes sense on its own. ### Must wait for: - [x] rust-lang#151695

Rollup merge of #151691 - Enselic:dylib-only-for-prefer-dynamic-v2, r=jdonszelmann compiletest: Don't assume `aux-crate` becomes a `*.so` with `no-prefer-dynamic` Since it does not make sense to do so. If someone prefers no dynamic stuff, the last thing they want to look for is an .so file. Also add a regression test. Without the fix, the test fails with: error: test compilation failed although it shouldn't! --- stderr ------------------------------- error: extern location for no_prefer_dynamic_lib does not exist: .../auxiliary/libno_prefer_dynamic_lib.so --> .../no-prefer-dynamic-means-no-so.rs:9:5 | LL | no_prefer_dynamic_lib::return_42(); | ^^^^^^^^^^^^^^^^^^^^^ ### Needed by: - #150591 because of #151271. But IMHO this PR makes sense on its own. ### Must wait for: - [x] #151695

…=jdonszelmann compiletest: Don't assume `aux-crate` becomes a `*.so` with `no-prefer-dynamic` Since it does not make sense to do so. If someone prefers no dynamic stuff, the last thing they want to look for is an .so file. Also add a regression test. Without the fix, the test fails with: error: test compilation failed although it shouldn't! --- stderr ------------------------------- error: extern location for no_prefer_dynamic_lib does not exist: .../auxiliary/libno_prefer_dynamic_lib.so --> .../no-prefer-dynamic-means-no-so.rs:9:5 | LL | no_prefer_dynamic_lib::return_42(); | ^^^^^^^^^^^^^^^^^^^^^ ### Needed by: - rust-lang/rust#150591 because of rust-lang/rust#151271. But IMHO this PR makes sense on its own. ### Must wait for: - [x] rust-lang/rust#151695

Enselic force-pushed the proc-macro-priv-v2 branch from 4d31092 to 996d72b Compare January 26, 2026 15:36

Enselic mentioned this pull request Jan 26, 2026

compiletest: Don't assume aux-crate becomes a *.so with no-prefer-dynamic #151691

Merged

1 task

rustbot assigned Zalathar Jan 26, 2026

Enselic marked this pull request as ready for review January 26, 2026 17:06

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 26, 2026

Enselic changed the title ~~compiletest: Support --extern options with proc-macro directive~~ compiletest: Support --extern modifiers with proc-macro directive Jan 26, 2026

Enselic mentioned this pull request Jan 26, 2026

compiletest: Support --extern options with proc-macro directive #151258

Closed

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 2, 2026

JonathanBrouwer mentioned this pull request Feb 2, 2026

Rollup of 11 pull requests #151997

Closed

This was referenced Feb 2, 2026

Rollup of 11 pull requests #152005

Closed

Rollup of 12 pull requests #152006

Merged

rust-bors bot merged commit 0a7697c into rust-lang:main Feb 3, 2026
11 checks passed

rustbot added this to the 1.95.0 milestone Feb 3, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

compiletest: Support `--extern` modifiers with `proc-macro` directive #151695

compiletest: Support `--extern` modifiers with `proc-macro` directive #151695

Enselic commented Jan 26, 2026 •

edited by Zalathar

Loading

Uh oh!

rustbot commented Jan 26, 2026

Uh oh!

Zalathar commented Feb 2, 2026

Uh oh!

rust-bors bot commented Feb 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

compiletest: Support --extern modifiers with proc-macro directive #151695

compiletest: Support --extern modifiers with proc-macro directive #151695

Conversation

Enselic commented Jan 26, 2026 • edited by Zalathar Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unblocks:

Uh oh!

rustbot commented Jan 26, 2026

Uh oh!

Zalathar commented Feb 2, 2026

Uh oh!

rust-bors bot commented Feb 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

compiletest: Support `--extern` modifiers with `proc-macro` directive #151695

compiletest: Support `--extern` modifiers with `proc-macro` directive #151695

Enselic commented Jan 26, 2026 •

edited by Zalathar

Loading