Conversation
- Imported Tooltip from @cloudflare/kumo - Wrapped icon-only remove member and remove group buttons with Tooltips - Added window.confirm dialogs to handleRemove, handleRemoveGroup, and handleTransfer to prevent accidental destructive actions - Verified changes with Playwright screenshot testing Co-authored-by: schmug <38227427+schmug@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Deploying with Â
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
ais-hub | 6f5ea00 | Commit Preview URL Branch Preview URL |
Jul 17 2026, 05:42 AM |
Deploying with Â
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
agentic-inbox | 6f5ea00 | Jul 17 2026, 05:43 AM |
|
Closing as superseded by #653. This is one of 10 re-derivations of the same ACL confirmation-dialog change, opened by a Jules persona that has since been paused. #653 is the one kept open: it is the only variant that guards all four destructive actions including "Lock down", and it carries the clearest confirmation copy. Every variant edits |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
This pull request introduces small micro-UX enhancements to the
AclMembersPanelcomponent.Tooltipwrappers for mouse hover hints (matching their existing screen-readeraria-labels).handleRemove,handleRemoveGroup,handleTransfer) now prompt the user with a nativewindow.confirmdialog before firing the mutation, preventing accidental misclicks.PR created automatically by Jules for task 2689333424985906490 started by @schmug