You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The alternative to this fix would be to bump the min version of scipp in the runtime dependencies of essreduce...
In my opinion being aggresive in dropping old version is better as we currently have the luxury of not having too many downstream users 😅 and we don't need to maintain these quirks.
In my opinion being aggresive in dropping old version is better as we currently have the luxury of not having too many downstream users 😅 and we don't need to maintain these quirks.
Could be, but in this case, it was such a small change in a single place, that I thought it wasn't worth the time trying to dig through all the releases to find the one with the change. Also, it's not that essreduce can't work at all with the older scipp, so I think being lenient with requirements is worth it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Older versions of scipp require a list and do not work with a set in
drop_coords.This is to fix the nightly test at lower bounds.
The alternative to this fix would be to bump the min version of
scippin the runtime dependencies ofessreduce...