INNER_DTABLE_STORAGE_SERVER_URL - #902
Open
SkywalkerSpace wants to merge 1 commit into
Open
SkywalkerSpace wants to merge 1 commit into
SkywalkerSpace wants to merge 1 commit into
Conversation
seafile-dev
reviewed
Aug 13, 2026
seafile-dev
left a comment
seafile-dev
left a comment
There was a problem hiding this comment.
Verdict: Comment
Warnings:
- The configuration-key rename drops existing
DTABLE_STORAGE_SERVER_URLYAML/environment deployments; see inline comment.
Suggested fix: retain the old key as a fallback while preferringINNER_DTABLE_STORAGE_SERVER_URL, then document the new variable and migration in seatable-admin-docs.
|
|
||
| # storage server | ||
| DTABLE_STORAGE_SERVER_URL = configs.get('DTABLE_STORAGE_SERVER_URL', default='http://127.0.0.1:6666') | ||
| INNER_DTABLE_STORAGE_SERVER_URL = configs.get('INNER_DTABLE_STORAGE_SERVER_URL', default='http://127.0.0.1:6666') |
There was a problem hiding this comment.
[Warning] Preserve existing storage configuration
Why this matters:
This replaces the established DTABLE_STORAGE_SERVER_URL setting rather than adding an environment override. Existing YAML deployments that set that key now resolve to the loopback default, so a distributed deployment can silently start using the wrong storage server after upgrading.
Suggested fix: prefer INNER_DTABLE_STORAGE_SERVER_URL, but fall back to DTABLE_STORAGE_SERVER_URL when it is unset; document the new name and migration path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.