Skip to content

INNER_DTABLE_STORAGE_SERVER_URL #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SkywalkerSpace wants to merge 1 commit into
base: master
Choose a base branch
from
Open

INNER_DTABLE_STORAGE_SERVER_URL #902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dtable_events/app/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ def get_llm_prices(models):
UNIVERSAL_APP_SNAPSHOT_AUTO_SAVE_DAYS = configs.get('UNIVERSAL_APP_SNAPSHOT_AUTO_SAVE_DAYS', default=7)

# storage server
DTABLE_STORAGE_SERVER_URL = configs.get('DTABLE_STORAGE_SERVER_URL', default='http://127.0.0.1:6666')
INNER_DTABLE_STORAGE_SERVER_URL = configs.get('INNER_DTABLE_STORAGE_SERVER_URL', default='http://127.0.0.1:6666')

@seafile-dev seafile-dev Aug 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Warning] Preserve existing storage configuration

Why this matters:
This replaces the established DTABLE_STORAGE_SERVER_URL setting rather than adding an environment override. Existing YAML deployments that set that key now resolve to the loopback default, so a distributed deployment can silently start using the wrong storage server after upgrading.

Suggested fix: prefer INNER_DTABLE_STORAGE_SERVER_URL, but fall back to DTABLE_STORAGE_SERVER_URL when it is unset; document the new name and migration path.


# org member quota
ORG_MEMBER_QUOTA_DEFAULT = configs.get('ORG_MEMBER_QUOTA_DEFAULT', 10)
Expand Down
4 changes: 2 additions & 2 deletions dtable_events/utils/dtable_storage_server_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import uuid
import requests

from dtable_events.app.config import DTABLE_STORAGE_SERVER_URL
from dtable_events.app.config import INNER_DTABLE_STORAGE_SERVER_URL


TIMEOUT = 90
Expand Down Expand Up @@ -37,7 +37,7 @@ def __init__(self):
"""
:param server_url: str
"""
self.server_url = DTABLE_STORAGE_SERVER_URL.rstrip('/')
self.server_url = INNER_DTABLE_STORAGE_SERVER_URL.rstrip('/')

def __str__(self):
return '<DTable Storage Server API [ %s ]>' % self.server_url
Expand Down
Loading