Repository navigation
build: add CI workflow and fix flaky compaction test - #1
Merged
Merged
Conversation
No GitHub Actions workflow existed. Adds one running go build, go vet and go test -race with a coverage summary on push and PR. TestCompactionDuringConcurrentUse signalled its compaction goroutine to stop with close(stop) but never joined it, so the goroutine could call Compact() after s.Close() and fail intermittently with 'store is closed' (failed ~5 of 6 runs without -race). Join it with a WaitGroup before Close. Passes 6/6 without -race and under -race.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI
The repo had no GitHub Actions workflow. Adds one (
build-test) runninggo build,go vetandgo test ./... -racewith a coverage summary, on push to main and on PRs. Pinned to Go 1.26.4 (matches go.mod).Flaky test
TestCompactionDuringConcurrentUsesignalled its background compaction goroutine withclose(stop)but never joined it, so the goroutine could callCompact()afters.Close()and fail intermittently with "store is closed" (~5 of 6 runs without-race). Joined it with aWaitGroupbeforeClose.Verified: 6/6 passes without
-race, full suite green plain and under-race,go vetclean.Follow-ups (separate PRs): a govulncheck job needs a Go toolchain bump first; a golangci-lint job needs a config pass.