Download surface for the macOS companion - #170
Merged
Merged
Conversation
/download resolves the newest DMG from GitHub Releases at request time (5-minute revalidate) and degrades to an honest coming-soon state while no release exists, so the page never links a 404 or claims a build that is not there. 404 is the one silent degradation; every other resolver failure logs with rate-limit context, and GITHUB_TOKEN is used when set. /download joins the middleware public paths (it previously bounced logged-out visitors to /login), the landing page and the in-app companion install prompt route through it, and it lands in the sitemap and the public-route smoke check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
/downloadon getminutia.com.releases/latestis the one expected, silent degradation; every other failure (rate limit, 5xx, malformed body, missing tag) logs with rate-limit context so a broken resolver cannot masquerade as "no release yet".GITHUB_TOKENis attached when configured./downloadadded to middleware public paths; it previously redirected logged-out visitors to/login./download, centralizing degradation in one place.Copy verified against the desktop repo: macOS 14.4+, universal binary. Two independent reviews (spec + silent-failure); all findings fixed: resolver observability, 300s revalidate bound on transient-failure cache pinning, honest version handling, truthful coming-soon copy.