Classify /download for the authz gate and fix the install-prompt href assertion - #173
Merged
Conversation
… assertion The download-page merge left main red in two spots the branch CI could not see: /download was unclassified in the hermetic authz manifest, and the companion install-prompt e2e still asserted the old GitHub releases href after the component moved to /download. /download is declared as a public screen (all identities pass; it sits in middleware publicPaths with no authed redirect) and the spec asserts the new internal href.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main went red after #170: the branch-level CI could not see two cross-PR conflicts.
/downloadwas unclassified in the hermetic authz manifest, failing the coverage gate. It is now declared as a public screen (all identities pass; it sits in middlewarepublicPathswith no authed redirect), so the gate executes it through the real middleware like the other public pages./download.Local:
pnpm test:authz23/23, tsc and lint clean.