Skip to content

Classify /download for the authz gate and fix the install-prompt href assertion #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pratikbodkhe merged 1 commit into from
Jul 20, 2026
Merged

Classify /download for the authz gate and fix the install-prompt href assertion #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions e2e/regression/companion-handshake.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ const TEST_USER_ID = "00000000-0000-0000-0000-000000000001";

const PROMPT_COPY =
"For the best experience, download and install the companion app.";
const DOWNLOAD_URL =
"https://github.com/shiprite-dev/minutia-desktop/releases/latest";
const DOWNLOAD_URL = "/download";

function serviceHeaders(prefer = "return=representation") {
const key = process.env.SUPABASE_SERVICE_ROLE_KEY;
Expand Down
1 change: 1 addition & 0 deletions scripts/authz/nodes.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ export const manifest = [
{ id: "screen:/", kind: "screen", url: "/" },
{ id: "screen:/login", kind: "screen", url: "/login" },
{ id: "screen:/signup", kind: "screen", url: "/signup" },
{ id: "screen:/download", kind: "screen", url: "/download" },
{ id: "screen:/reset-password", kind: "screen", url: "/reset-password" },
{ id: "screen:/accept-invite", kind: "screen", url: "/accept-invite" },
{ id: "screen:/setup", kind: "screen", url: "/setup" },
Expand Down
5 changes: 5 additions & 0 deletions scripts/authz/policy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@
"note": "public signup disabled on self-host default (ENABLE_PUBLIC_SIGNUP!=true) -> redirect /login for everyone, before auth",
"expect": { "loggedOut": "redirect:/login", "member": "redirect:/login", "orgAdmin": "redirect:/login", "globalAdmin": "redirect:/login", "crossTenant": "redirect:/login", "proMember": "redirect:/login" }
},
"screen:/download": {
"kind": "screen",
"note": "public companion download page; in middleware publicPaths, no authed redirect",
"expect": { "loggedOut": "pass", "member": "pass", "orgAdmin": "pass", "globalAdmin": "pass", "crossTenant": "pass", "proMember": "pass" }
},
"screen:/reset-password": {
"kind": "screen",
"expect": { "loggedOut": "pass", "member": "pass", "orgAdmin": "pass", "globalAdmin": "pass", "crossTenant": "pass", "proMember": "pass" }
Expand Down
Loading