Add Gloas Builder API client and adapt execution layer (Gloas builder API 2/5) - #9804
Conversation
|
This pull request is part of a Mergify stack:
|
9274899 to
d1cbba9
Compare
Revision history
|
d1cbba9 to
490d128
Compare
482984b to
0ca9777
Compare
0ca9777 to
510e3a2
Compare
pawanjay176
left a comment
There was a problem hiding this comment.
Very neat. This was a joy to review.
Just a few notes, nothing blocking merge
| .create(); | ||
| assert!(request_bid(&server).await.is_none()); | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we also add a test for checking headers are as expected?
| /// is likewise a proposer policy applied by the caller (see `DirectBid::min_bid`), not here. These | ||
| /// pipelines run | ||
| /// **concurrently across builders**, so a slow builder or an expensive validation for one bid | ||
| /// does not hold up the others. A failure, timeout, empty (204) response, or validation error |
There was a problem hiding this comment.
Nice, just noting that the timeout doesn't apply to the validation. So we need to make sure that validation takes predictable amount of time regardless of the content of the bid.
Probably handled in the next PR, but just flagging here in case.
510e3a2 to
06b84f3
Compare
06b84f3 to
2d74338
Compare
120d9ca to
c0283d0
Compare
pawanjay176
left a comment
There was a problem hiding this comment.
Nice, lets try to get 1 and 2 in
|
@mergify queue |
Merge Queue Status
This pull request spent 36 minutes 9 seconds in the queue, including 29 minutes 9 seconds running CI. Required conditions to merge
ReasonPull request #9804 has been dequeued Mergify failed to merge the pull request. GitHub can't merge the pull request after 2 minutes of retrying.
HintYou should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. Requeued — the merge queue status continues in this comment ↓. |
… API 2/5) Second PR of the Gloas builder API stack (builder-specs #165): - builder_client: relocate the legacy MEV-boost client to `PreGloasBuilderHttpClient` and add the Gloas Builder API HTTP client (request-auth, bid requests, preference submission, signed-block forwarding) plus the stateless `Builders` service used by block production - execution_layer: adopt the relocated pre-Gloas client and drop dead error variants The new client is not yet wired into the beacon chain; that lands in the next PR of this stack. Change-Id: I5bcab56ff499b183f26cc90697bc7c7f2baddfe7
c0283d0 to
ee05f36
Compare
|
@mergify queue |
Merge Queue Status
This pull request spent 29 minutes 26 seconds in the queue, including 27 minutes 23 seconds running CI. Required conditions to merge
|
Second PR of the Gloas builder API stack (builder-specs #165):
PreGloasBuilderHttpClientand add the Gloas Builder API HTTP client(request-auth, bid requests, preference submission, signed-block forwarding)
plus the stateless
Buildersservice used by block productionvariants
The new client is not yet wired into the beacon chain; that lands in the next
PR of this stack.