Add Gloas bid selection, block production, and bid gossip processing (Gloas builder API 3/5) - #9805
Open
ethDreamer wants to merge 1 commit into
Conversation
Member
Author
|
This pull request is part of a Mergify stack:
|
ethDreamer
force-pushed
the
stack/ethDreamer/gloas-builder-api-stacked/add-gloas-bid-selection-block-prod-bid-gossip--eccaee5d
branch
from
August 13, 2026 23:39
cfe5775 to
ea4ef14
Compare
Member
Author
Revision history
|
ethDreamer
force-pushed
the
stack/ethDreamer/gloas-builder-api-stacked/add-gloas-bid-selection-block-prod-bid-gossip--eccaee5d
branch
from
August 14, 2026 00:03
ea4ef14 to
46ee0fa
Compare
ethDreamer
force-pushed
the
stack/ethDreamer/gloas-builder-api-stacked/add-gloas-bid-selection-block-prod-bid-gossip--eccaee5d
branch
2 times, most recently
from
August 17, 2026 16:52
1ad80bd to
9b3cb1f
Compare
ethDreamer
force-pushed
the
stack/ethDreamer/gloas-builder-api-stacked/add-gloas-bid-selection-block-prod-bid-gossip--eccaee5d
branch
from
August 18, 2026 17:51
9b3cb1f to
e71bb39
Compare
ethDreamer
force-pushed
the
stack/ethDreamer/gloas-builder-api-stacked/add-gloas-bid-selection-block-prod-bid-gossip--eccaee5d
branch
from
August 19, 2026 19:31
e71bb39 to
c3501ac
Compare
ethDreamer
force-pushed
the
stack/ethDreamer/gloas-builder-api-stacked/add-gloas-bid-selection-block-prod-bid-gossip--eccaee5d
branch
from
August 19, 2026 21:58
c3501ac to
f95e1b9
Compare
ethDreamer
force-pushed
the
stack/ethDreamer/gloas-builder-api-stacked/add-gloas-bid-selection-block-prod-bid-gossip--eccaee5d
branch
from
August 20, 2026 17:50
f95e1b9 to
bd0b326
Compare
ethDreamer
force-pushed
the
stack/ethDreamer/gloas-builder-api-stacked/add-gloas-bid-selection-block-prod-bid-gossip--eccaee5d
branch
from
August 20, 2026 21:41
bd0b326 to
12a2374
Compare
ethDreamer
force-pushed
the
stack/ethDreamer/gloas-builder-api-stacked/add-gloas-bid-selection-block-prod-bid-gossip--eccaee5d
branch
from
August 20, 2026 23:35
12a2374 to
332a33e
Compare
Base automatically changed from
stack/ethDreamer/gloas-builder-api-stacked/add-gloas-builder-api-client-adapt-execution--5bcab56f
to
unstable
August 21, 2026 00:18
ethDreamer
force-pushed
the
stack/ethDreamer/gloas-builder-api-stacked/add-gloas-bid-selection-block-prod-bid-gossip--eccaee5d
branch
from
August 21, 2026 14:15
332a33e to
db7f733
Compare
…(Gloas builder API 3/5) Third PR of the Gloas builder API stack: - beacon_chain: direct builder bid verification (spawned on the blocking executor), gossip-bid refinements, wei-domain bid selection (`BidCandidate`/`BidSource`), and Gloas block production that assembles local, gossip, and direct-builder candidates - network: process payload-bid and proposer-preference gossip, including the new `PayloadBidError` variants - client: construct the `Builders` service when the Gloas fork is scheduled and wire it into the beacon chain The HTTP API still serves `GET` produceBlockV4 at this point; the `POST` conversion and the `Eth-Builder-Url` round-trip land in the next PR. Change-Id: Ieccaee5db81bf871c19cef1b79fc48283be9dd51
ethDreamer
force-pushed
the
stack/ethDreamer/gloas-builder-api-stacked/add-gloas-bid-selection-block-prod-bid-gossip--eccaee5d
branch
from
August 24, 2026 18:03
db7f733 to
1ab6945
Compare
pawanjay176
approved these changes
Aug 25, 2026
pawanjay176
left a comment
pawanjay176
left a comment
Member
There was a problem hiding this comment.
Just one minor question as a blocker, everything else looks great.
Really nice separation of concerns with bid_selection.rs.
Enjoyed reviewing this one as well!
| ) => { | ||
| self.propagate_validation_result(message_id, peer_id, MessageAcceptance::Ignore); | ||
| } | ||
| // `InvalidParentBlockHash` / `InvalidParentBlockRoot` are equality checks against the |
Member
There was a problem hiding this comment.
Maybe we move these explanations to the Error enum like we do with other gossip errors?
| // The gas limit must be compatible with the parent's, given the proposer's target. | ||
| if let Ok(parent_bid) = state.latest_execution_payload_bid() | ||
| && !is_gas_limit_target_compatible( | ||
| parent_bid.gas_limit, |
Member
There was a problem hiding this comment.
the parent gas limit would be different depending on whether we are building on full or empty here right?
| /// The proposer's boost multiplier for this candidate; `100` (neutral) for the local build. | ||
| builder_boost_factor: u64, | ||
| /// The proposer's `min_bid` acceptance floor (gwei) for this candidate; `0` for the local build, | ||
| /// which is the proposer's own block and is never gated. |
Member
There was a problem hiding this comment.
what does "is never gated" mean here?
| pub fn select_payload_bid<E: EthSpec>(candidates: Vec<BidCandidate<E>>) -> Option<BidCandidate<E>> { | ||
| // `reduce` keeps `best` unless `candidate` is *strictly* greater, so the earliest of any tied | ||
| // maxima wins. | ||
| candidates.into_iter().reduce(|best, candidate| { |
Member
There was a problem hiding this comment.
@jimmygchen would appreciate your review on this file. Just want to confirm that this makes sense from the builder perspective
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third PR of the Gloas builder API stack:
executor), gossip-bid refinements, wei-domain bid selection
(
BidCandidate/BidSource), and Gloas block production that assembleslocal, gossip, and direct-builder candidates
new
PayloadBidErrorvariantsBuildersservice when the Gloas fork is scheduledand wire it into the beacon chain
The HTTP API still serves
GETproduceBlockV4 at this point; thePOSTconversion and the
Eth-Builder-Urlround-trip land in the next PR.