Repository navigation
Fix Clippy loop-counter lint in solvate residue assignment - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clippy fails in
crates/bio-forge/src/ops/solvate.rsbecauseres_id_counterwas used as a manual loop counter when assigning IDs to generated water residues. This updates the loop to use idiomatic iterator zipping while preserving residue ID sequencing and insertion order.Root cause
for mut residue in new_waters.Code change
(1..).zip(new_waters)and destructured(res_id_counter, mut residue)in the loop.residue.idassignmentsolvent_chain.add_residue(residue)water_positions.push(res_id_counter)Representative diff