Skip to content

Fix Clippy loop-counter lint in solvate residue assignment #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colbyford merged 2 commits into from
May 23, 2026
Merged

Fix Clippy loop-counter lint in solvate residue assignment #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb4b5ec
Fix Clippy explicit-counter-loop in solvate
Copilot May 23, 2026
03af102
Remove redundant into_iter in solvate loop
Copilot May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions crates/bio-forge/src/ops/solvate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,13 +316,10 @@ pub fn solvate_structure(structure: &mut Structure, config: &SolvateConfig) -> R

let mut water_positions = Vec::with_capacity(new_waters.len());
solvent_chain.reserve(new_waters.len());
let mut res_id_counter = 1;

for mut residue in new_waters {
for (res_id_counter, mut residue) in (1..).zip(new_waters) {
residue.id = res_id_counter;
solvent_chain.add_residue(residue);
water_positions.push(res_id_counter);
res_id_counter += 1;
}

replace_with_ions(
Expand Down
Loading