Skip to content

Measure a real export before shipping, and title a one page site properly - #434

Merged
singhharsh1708 merged 1 commit into
mainfrom
feat/export-gate
Oct 3, 2026
Merged

singhharsh1708 merged 1 commit into
mainfrom
feat/export-gate

Conversation

@singhharsh1708

Copy link
Copy Markdown
Owner

Fixes #417, and fixes a regression it found on its first run.

npm run check:export -- --slug weft exports that template through the running app, serves the result as a plain folder the way anybody hosts it, runs Lighthouse against that, and exits non-zero under 95 performance or 100 accessibility. Numbers in the README and anywhere else now come from a command rather than from memory.

Measured today, four templates: kept, aurabeauty, weft and orbitcrm each score 100 performance, 100 accessibility, 100 SEO, 96 best practices. Asking for 101 performance makes it exit 1 and say why, and an unknown template name exits 1 rather than measuring something else.

The export route now accepts template: "<slug>" and fills in that template's sections, theme, style, name and description, with anything sent alongside winning. The editor does not need it; the gate and the plugin do.

The regression: since #426 every single page export has been titling the browser tab and the share card "Home" instead of the site's name. The page list calls its first entry Home, which is right in a nav beside About and Contact and wrong on a site with no other page. Writing a test for the template export is what surfaced it. Both cases are pinned now, and the multi-page titles are unchanged.

One mistake worth recording, because it cost the first run: the script used spawnSync for Lighthouse, which blocks this process's event loop, so the server it had just started could not answer a single request and Chrome died with "Target closed" against a server that was listening and deaf. It spawns asynchronously now, and a test fails if that comes back.

tsc and eslint clean, vitest 716 of 716.

@vercel

vercel Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
scrollcraft Ready Ready Preview Oct 3, 2026 1:43pm UTC

@singhharsh1708
singhharsh1708 merged commit f3659e1 into main Oct 3, 2026
3 checks passed
@singhharsh1708
singhharsh1708 deleted the feat/export-gate branch October 3, 2026 13:44

This branch was successfully deployed

1 active deployment
Preview — 1dc1f4f4 Deployed Oct 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Measure every new export before it lands

1 participant