chore: release v0.6.28 — ship pipeline auto-commit - #564
Merged
Conversation
githubrobbi
enabled auto-merge
July 20, 2026 00:51
The prior CodeQL run's Initialize step failed on "Encountered an error while trying to determine feature enablement: HttpError: No server is currently available" — GitHub's own API was degraded at that moment, unrelated to this branch's content. Empty commit to get a clean CI run against the same tree.
githubrobbi
enabled auto-merge
July 20, 2026 01:16
gh api's stdout on a 5xx error is its JSON error body, but the command still exits non-zero; the existing `|| true` swallowed the exit code while EXISTING_ID still captured that JSON text as if it were a real comment id. The subsequent DELETE/PATCH call then crashed on the garbage URL, failing this *required* gate for a reason unrelated to title conformance (release PR #564 hit this: title conformed, the stale-comment-cleanup lookup 503'd, and the whole job died). Validate EXISTING_ID is purely numeric before trusting it; anything else (including a JSON error blob) is treated as "no existing comment" so the conformance result stands on its own.
3 tasks
Two tests inferred concurrency from `elapsed < sequential_estimate * 3 / 4` (100ms-per-operation fixtures). That's only ever true relative to how fast the machine happens to be that run: on a loaded/throttled GitHub-hosted Windows runner, thread::sleep(100ms) itself can take several hundred milliseconds of wall-clock time, which pushes *both* the sequential and concurrent paths past any fixed absolute threshold. Hit for real in release PR #564's merge-queue run: elapsed 889ms vs. a 600ms "fully sequential" estimate -- worse than fully sequential, which is only possible under uniform scheduling overhead, not an actual concurrency regression (the dispatch code was independently re-verified: `emit::read_and_emit_all_candidates` and `workflow::enumerate_all_roots_concurrently` both still spawn one thread per lease/root via `std::thread::scope`). Replace the wall-clock-ratio assertion with direct proof: record every operation's (start, end) Instant and assert at least two intervals overlap. Two things overlapping in time is true or false independent of how slow the machine is -- it only asks whether they ran at the same time, which is what "concurrent" actually means. Verified 15/15 consecutive local runs; xwin cross-compile clean; lint-tests (pedantic + nursery) clean.
4 tasks
githubrobbi
enabled auto-merge
July 20, 2026 02:21
deep-soft
pushed a commit
to deep-soft/UltraFastFileSearch-Rust
that referenced
this pull request
Jul 20, 2026
…llc-ai#566) Two tests inferred concurrency from `elapsed < sequential_estimate * 3 / 4` (100ms-per-operation fixtures). That's only ever true relative to how fast the machine happens to be that run: on a loaded/throttled GitHub-hosted Windows runner, thread::sleep(100ms) itself can take several hundred milliseconds of wall-clock time, which pushes *both* the sequential and concurrent paths past any fixed absolute threshold. Hit for real in release PR skyllc-ai#564's merge-queue run: elapsed 889ms vs. a 600ms "fully sequential" estimate -- worse than fully sequential, which is only possible under uniform scheduling overhead, not an actual concurrency regression (the dispatch code was independently re-verified: `emit::read_and_emit_all_candidates` and `workflow::enumerate_all_roots_concurrently` both still spawn one thread per lease/root via `std::thread::scope`). Replace the wall-clock-ratio assertion with direct proof: record every operation's (start, end) Instant and assert at least two intervals overlap. Two things overlapping in time is true or false independent of how slow the machine is -- it only asks whether they ran at the same time, which is what "concurrent" actually means. Verified 15/15 consecutive local runs; xwin cross-compile clean; lint-tests (pedantic + nursery) clean.
deep-soft
pushed a commit
to deep-soft/UltraFastFileSearch-Rust
that referenced
this pull request
Jul 20, 2026
…ate (skyllc-ai#565) gh api's stdout on a 5xx error is its JSON error body, but the command still exits non-zero; the existing `|| true` swallowed the exit code while EXISTING_ID still captured that JSON text as if it were a real comment id. The subsequent DELETE/PATCH call then crashed on the garbage URL, failing this *required* gate for a reason unrelated to title conformance (release PR skyllc-ai#564 hit this: title conformed, the stale-comment-cleanup lookup 503'd, and the whole job died). Validate EXISTING_ID is purely numeric before trusting it; anything else (including a JSON error blob) is treated as "no existing comment" so the conformance result stands on its own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
just shipPhase 2 auto-commit for v0.6.28 — the[workspace.package].versionbump inCargo.toml. This PR routes that commit through branch-protection rules. Once it merges tomain, runjust release-tagto cut the signedv0.6.28tag, which firesrelease.ymland builds the cross-platform binaries + GitHub Release v0.6.28. (No auto-tag on merge — the tag step is manual on-demand, Path B.)Auto-merge
--auto --squashis queued — GitHub will merge as soon as the required status checks pass. Squash is required becausemain-protectionmandates signed commits, and GitHub's rebase-auto-merge cannot sign the rebased commit; the squash-merge commit is signed by GitHub's own key, which satisfiesrequired_signatures: true. The original author's signed commit remains verifiable in the PR branch history.After merge
The auto-commit lived only on
release/v0.6.28, so localmainnever drifted — sync it with a plaingit pull --ff-only origin main(noreset --hardneeded).