fix(web): stop telemetry poll from overwriting config edits - #185
Merged
Merged
Conversation
loadTelemetry() polls /api/status every 2s and unconditionally wrote the Pool/Time tab form fields from the status JSON, even while the user was authenticated and editing. Any edit reverted within 2 seconds, and if the poll fired between the edit and the Save click, the save even persisted the reverted original value. Only populate these fields when unauthenticated (read-only display); /api/config via loadConfig() is the authoritative source once logged in.
Contributor
✅
|
| Descriptor | Linter | Files | Fixed | Errors | Max errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 8 | 0 | 0 | 0.75s | ||
| ✅ BASH | bash-exec | 2 | 0 | 0 | 0.62s | ||
| ✅ BASH | shellcheck | 2 | 0 | 0 | 0.61s | ||
| ✅ BASH | shfmt | 2 | 0 | 0 | 0.01s | ||
| ✅ C | clang-format | 1 | 0 | 0 | 0.05s | ||
| ✅ C | cppcheck | 1 | 0 | 0 | 0.05s | ||
| ✅ C | cpplint | 1 | 0 | 0 | 0.36s | ||
| ✅ CPP | clang-format | 82 | 0 | 0 | 0.77s | ||
| ✅ CPP | cppcheck | 82 | 0 | 0 | 6.38s | ||
| ✅ CPP | cpplint | 82 | 0 | 0 | 7.39s | ||
| ✅ EDITORCONFIG | editorconfig-checker | 262 | 0 | 0 | 0.65s | ||
| ✅ JSON | jsonlint | 6 | 0 | 0 | 0.17s | ||
| ✅ JSON | v8r | 6 | 0 | 0 | 4.37s | ||
| markdownlint | 103 | 3 | 0 | 4.18s | |||
| ✅ YAML | yamllint | 25 | 0 | 0 | 0.83s |
Detailed Issues
⚠️ MARKDOWN / markdownlint - 3 errors
.opencode/skills/web-ui/SKILL.md:34 error MD028/no-blanks-blockquote Blank line inside blockquote
docs/superpowers/plans/2026-08-10-olimex-c6-local-ui-implementation.md:106:401 error MD013/line-length Line length [Expected: 400; Actual: 452]
docs/superpowers/plans/2026-08-16-norvi-button-calibration.md:7:401 error MD013/line-length Line length [Expected: 400; Actual: 412]
Notices
MAKEFILE, MAKEFILE_CHECKMAKE, MARKDOWN_MARKDOWN_LINK_CHECK. See Removed linters to find their replacements.
See detailed reports in MegaLinter artifacts
Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)
- Documentation: Custom Flavors
- Command:
npx mega-linter-runner@10.0.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,BASH_EXEC,BASH_SHELLCHECK,BASH_SHFMT,C_CPPCHECK,C_CPPLINT,C_CLANG_FORMAT,CPP_CPPCHECK,CPP_CPPLINT,CPP_CLANG_FORMAT,EDITORCONFIG_EDITORCONFIG_CHECKER,JSON_JSONLINT,JSON_V8R,MARKDOWN_MARKDOWNLINT,YAML_YAMLLINT

Show us your support by starring ⭐ the repository
Contributor
Native Test Coverage
Report from native unit tests (ASan + gcov). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The 2-second telemetry poll (
loadTelemetry()) unconditionally wrote the Pool/Time tab form fields from/api/status— even while the user was authenticated and editing. Any in-progress edit was reset to the server value within 2 seconds, and if the poll fired between the edit and the Save click, the save even persisted the reverted original value.Fix
Only populate these fields when unauthenticated (read-only display). Once logged in,
/api/config(vialoadConfig()) is the authoritative source and the poll no longer touches the form fields. Invalid input is still rejected by the existing frontend validation (validateSettings()).Verification
node --check data/web/app.jspassesapp.jsconfirmed to contain the guard