Skip to content

fix(web): stop telemetry poll from overwriting config edits #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stritti merged 1 commit into from
Aug 20, 2026
Merged

fix(web): stop telemetry poll from overwriting config edits #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 32 additions & 25 deletions data/web/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,33 +169,40 @@ async function loadTelemetry() {
updateAuthUI();

// ── Pool & Time Tab (read-only params from /api/status) ──
const statusFields = [
['loopInterval', data.loop_interval],
['tempMaxPool', data.temp_max_pool],
['tempMinSolar', data.temp_min_solar],
['tempHysteresis', data.temp_hysteresis],
['tempCircThreshold', data.temp_circ_threshold],
['tempCircFactor', data.temp_circ_factor],
['tempCircMaxRuntime', data.temp_circ_max_runtime],
['timezone', data.timezone],
['timeLossGreen', data.time_loss_green_hours],
['timeLossRed', data.time_loss_red_hours],
['ntpServer', data.ntp_server],
];
for (const [id, val] of statusFields) {
if (val != null) {
const el = document.getElementById(id);
if (el) el.value = val;
// Only populate these form fields when NOT authenticated: /api/config is
// the authoritative source once logged in (loadConfig fills them), and a
// telemetry poll here would otherwise overwrite the user's in-progress
// edits every 2 seconds. When unauthenticated the fields are disabled,
// so this read-only display is harmless.
if (!isAuthenticated) {
const statusFields = [
['loopInterval', data.loop_interval],
['tempMaxPool', data.temp_max_pool],
['tempMinSolar', data.temp_min_solar],
['tempHysteresis', data.temp_hysteresis],
['tempCircThreshold', data.temp_circ_threshold],
['tempCircFactor', data.temp_circ_factor],
['tempCircMaxRuntime', data.temp_circ_max_runtime],
['timezone', data.timezone],
['timeLossGreen', data.time_loss_green_hours],
['timeLossRed', data.time_loss_red_hours],
['ntpServer', data.ntp_server],
];
for (const [id, val] of statusFields) {
if (val != null) {
const el = document.getElementById(id);
if (el) el.value = val;
}
}
}

// Timer start/end fields on Pool tab
if (data.timer_start_h != null) {
const pad2 = (n) => n.toString().padStart(2, '0');
const stEl = document.getElementById('timerStart');
if (stEl) stEl.value = pad2(data.timer_start_h) + ':' + pad2(data.timer_start_m);
const etEl = document.getElementById('timerEnd');
if (etEl) etEl.value = pad2(data.timer_end_h) + ':' + pad2(data.timer_end_m);
// Timer start/end fields on Pool tab
if (data.timer_start_h != null) {
const pad2 = (n) => n.toString().padStart(2, '0');
const stEl = document.getElementById('timerStart');
if (stEl) stEl.value = pad2(data.timer_start_h) + ':' + pad2(data.timer_start_m);
const etEl = document.getElementById('timerEnd');
if (etEl) etEl.value = pad2(data.timer_end_h) + ':' + pad2(data.timer_end_m);
}
}

// AP-Mode: WiFi-Tab anzeigen (nur einmalig — nicht bei jedem Poll erzwingen,
Expand Down
Loading