Bump action-send-mail to v18 and html-validation Node to 24#91
Merged
Conversation
Reviewed Renovate #88 / #89: - dawidd6/action-send-mail v3.12.0 -> v18. Verified across all majors v3..v18: the only breaking change affecting our usage is v12's `from` format requirement (user@example.com or "Name <user@example.com>"). SMTP_FROM produces From: github-notify@smkwlab.net (bare email) -> compliant. - html-validation Node 20 -> 24. Node 24 is current LTS (since 2025-10) and Node 20 is EOL (2026-04); node is only used for htmlhint + a trivial CSS brace check, both fine on 24. (The AI reviewer's "24 not LTS" note is stale.) Consolidated to clear the up-to-date-branch ruleset. Supersedes #88 / #89. Note: action-send-mail runs only on real PR events (not CI), so v18 email delivery is confirmed on the next ML notification after the v1 deploy. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JPuooHgsrboSEbfJsNf6iG
This was referenced Jul 4, 2026
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PRの変更内容を確認しました。Node.jsのバージョンアップ（20→24）とaction-send-mailのメジャーバージョンアップ（v3.12.0→v18）という2つの変更が含まれています。
Node 24はLTSとして適切な選択であり、htmlhintおよびCSSチェックのような軽量ツールへの影響は最小限です。action-send-mailについては、PRの説明にある通りv12の破壊的変更（fromフォーマット要件）が唯一の懸念点でしたが、SMTP_FROMがベアメールアドレスを生成するため準拠していることが確認されています。
全体的に変更は適切に検討されており、大きな問題は見当たりません。ただし、1点指摘事項があります。
|
|
||
| - name: Send notification email to lab ML | ||
| uses: dawidd6/action-send-mail@2cea9617b09d79a095af21254fbcb7ae95903dde # v3.12.0 | ||
| uses: dawidd6/action-send-mail@94de994a9f6fffee200243214e17002e2920bb59 # v18 |
There was a problem hiding this comment.
ℹ️ [LOW] action-send-mailがv3.12.0からv18という大幅なメジャーバージョンアップとなっています。PRの説明ではv12のfromフォーマット要件のみが破壊的変更として言及されていますが、v3からv18の間には多数のメジャーバージョンが存在します。
コミットハッシュによるピン留め（@94de994a9f6fffee200243214e17002e2920bb59）はセキュリティ上適切ですが、メール送信は実際のPRイベントでのみ実行されるため、デプロイ後まで動作確認ができない点に注意が必要です。
v3〜v18の全メジャー変更を精査済みとのことですが、可能であればステージング環境や手動トリガーでの事前検証を検討することを推奨します。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed Renovate #88 / #89.
action-send-mail v3.12.0 → v18: verified all majors v3..v18 — the only breaking change affecting our usage is v12's
fromformat requirement.SMTP_FROMproducesFrom: github-notify@smkwlab.net(bare email) → compliant. Other inputs stable. (Email send runs only on real PR events, so v18 delivery is confirmed on the next ML notification post-deploy.)html-validation Node 20 → 24: Node 24 is current LTS (since 2025-10), Node 20 is EOL (2026-04); node is only used for htmlhint + a trivial CSS check → fine on 24.
Supersedes #88 / #89.
🤖 Generated with Claude Code