Add dependency on imageio; remove matplotlib-based reader.#392
Merged
tacaswell merged 1 commit intosoft-matter:mainfrom Apr 12, 2022
Merged
Add dependency on imageio; remove matplotlib-based reader.#392tacaswell merged 1 commit intosoft-matter:mainfrom
tacaswell merged 1 commit intosoft-matter:mainfrom
Conversation
Member
|
@anntzer needs a rebase. |
matplotlib's imread is now anyways a thin shim around pillow (a dependency of matplotlib), so if you have matplotlib installed, you may as well use imageio's imread: imageio is a smaller dependency, and has more consistent behavior (it doesn't return pngs as floats). imageio is also a dependency of scikit-image (since 0.15), so it seems reasonable to directly depend on it instead. For now, the scikit-image reader was kept, as removing it (possibly in the future) would entail removing support for the `plugin` kwarg, and thus an API break.
Contributor
Author
|
Done. |
Codecov Report
@@ Coverage Diff @@
## main #392 +/- ##
==========================================
- Coverage 63.02% 63.00% -0.03%
==========================================
Files 31 31
Lines 4582 4538 -44
==========================================
- Hits 2888 2859 -29
+ Misses 1694 1679 -15
Continue to review full report at Codecov.
|
This was referenced Apr 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
matplotlib's imread is now anyways a thin shim around pillow (a
dependency of matplotlib), so if you have matplotlib installed, you may
as well use imageio's imread: imageio is a smaller dependency, and has
more consistent behavior (it doesn't return pngs as floats).
imageio is also a dependency of scikit-image (since 0.15), so it seems
reasonable to directly depend on it instead. For now, the scikit-image
reader was kept, as removing it (possibly in the future) would entail
removing support for the
pluginkwarg, and thus an API break.(See also #273 (comment).)