Emit structured compiler diagnostics in JSON output#3128
Closed
Arcticae wants to merge 1 commit into
Closed
Conversation
Arcticae
requested review from
maciektr and
wawel37
and removed request for
a team
Member
Author
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced May 19, 2026
Arcticae
force-pushed
the
arcticae/metadata-machine-diagnostics
branch
from
14613e1 to
0e4ad80
Compare
Arcticae
force-pushed
the
arcticae/compile-structured-json-diagnostics
branch
from
428836e to
4cc3d88
Compare
maciektr
requested changes
May 19, 2026
| } | ||
| } | ||
|
|
||
| pub fn check(&mut self, db: &dyn Database, sink: &mut impl StructuredDiagnosticsSink) -> bool { |
Contributor
There was a problem hiding this comment.
Can this be upstreamed to the compiler?
Member
Author
There was a problem hiding this comment.
Yes - this whole file is written in such a way to be copied-over directly without modifications once we verify we want to go forward with this approach.
Member
Author
There was a problem hiding this comment.
(that's why there's the StructuredDiagnosticsSink abstraction present here)
Arcticae
force-pushed
the
arcticae/metadata-machine-diagnostics
branch
from
0e4ad80 to
84cad29
Compare
Arcticae
force-pushed
the
arcticae/compile-structured-json-diagnostics
branch
from
4cc3d88 to
cb4f82b
Compare
Arcticae
force-pushed
the
arcticae/metadata-machine-diagnostics
branch
from
84cad29 to
fcffdb8
Compare
Arcticae
force-pushed
the
arcticae/compile-structured-json-diagnostics
branch
from
cb4f82b to
f1b1f10
Compare
Arcticae
force-pushed
the
arcticae/metadata-machine-diagnostics
branch
from
fcffdb8 to
e5a6b47
Compare
Arcticae
force-pushed
the
arcticae/compile-structured-json-diagnostics
branch
from
f1b1f10 to
f8bceaa
Compare
Arcticae
force-pushed
the
arcticae/metadata-machine-diagnostics
branch
from
e5a6b47 to
91b68f5
Compare
Arcticae
force-pushed
the
arcticae/compile-structured-json-diagnostics
branch
from
f8bceaa to
74f4fac
Compare
wawel37
approved these changes
May 22, 2026
Member
wawel37
left a comment
wawel37
left a comment
There was a problem hiding this comment.
Other than some nits seems fine
Comment on lines
+205
to
+209
| fn build_structured_diagnostic_message<'db, TEntry: DiagnosticEntry<'db>>( | ||
| db: &'db dyn Database, | ||
| entry: &TEntry, | ||
| file_notes: &PluginFileDiagnosticNotes<'db>, | ||
| ) -> Option<StructuredDiagnosticMessage> { |
Member
There was a problem hiding this comment.
Correct me if im wrong, but this function never returns None right? If so change the return type
Comment on lines
+160
to
+163
| found |= group.check_error_free().is_err(); | ||
| } | ||
| } | ||
| found |
Member
There was a problem hiding this comment.
Doesn't check_error_free check the whole group? If so whats the point of running it every time in loop. Once at the end is enough i think
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.