Parallelize structured compiler diagnostic collection#3129
Closed
Arcticae wants to merge 1 commit into
Closed
Conversation
Arcticae
requested review from
maciektr and
wawel37
and removed request for
a team
Member
Author
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced May 19, 2026
Arcticae
force-pushed
the
arcticae/compile-structured-json-diagnostics
branch
from
428836e to
4cc3d88
Compare
Arcticae
force-pushed
the
arcticae/compile-parallel-machine-diagnostics
branch
from
630e9c1 to
d79f475
Compare
Arcticae
force-pushed
the
arcticae/compile-structured-json-diagnostics
branch
from
4cc3d88 to
cb4f82b
Compare
Arcticae
force-pushed
the
arcticae/compile-parallel-machine-diagnostics
branch
from
d79f475 to
3d4ac15
Compare
maciektr
requested changes
May 19, 2026
Comment on lines
+55
to
+61
| let reports = self | ||
| .crates | ||
| .par_iter() | ||
| .map_with(db.dyn_clone(), |db, crate_input| { | ||
| self.collect_crate_diagnostics(db.as_ref(), crate_input) | ||
| }) | ||
| .collect::<Vec<_>>(); |
Contributor
There was a problem hiding this comment.
Why should we do this instead of the warmup style that Cairo does?
https://github.com/starkware-libs/cairo/blob/adf04c14281084d7ef7d383c8418888a5d49d992/crates/cairo-lang-compiler/src/lib.rs#L209
Contributor
There was a problem hiding this comment.
Also, would it make sense to paralelize on module level like Cairo does?
Arcticae
force-pushed
the
arcticae/compile-structured-json-diagnostics
branch
from
cb4f82b to
f1b1f10
Compare
Arcticae
force-pushed
the
arcticae/compile-parallel-machine-diagnostics
branch
6 times, most recently
from
2e430bc to
3f0826a
Compare
Arcticae
force-pushed
the
arcticae/compile-structured-json-diagnostics
branch
from
f1b1f10 to
f8bceaa
Compare
Arcticae
force-pushed
the
arcticae/compile-parallel-machine-diagnostics
branch
from
3f0826a to
286ed3d
Compare
# Conflicts: # scarb/src/compiler/structured_diagnostics/core.rs # scarb/src/compiler/structured_diagnostics/mod.rs
Arcticae
force-pushed
the
arcticae/compile-structured-json-diagnostics
branch
from
f8bceaa to
74f4fac
Compare
Arcticae
force-pushed
the
arcticae/compile-parallel-machine-diagnostics
branch
from
286ed3d to
d05a827
Compare
wawel37
reviewed
May 22, 2026
| message, | ||
| MachineDiagnosticSeverity::Error, | ||
| file, | ||
| MachineDiagnosticSpan { start: 0, end: 0 }, |
Member
There was a problem hiding this comment.
Same as 2 prs before, should be a default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.