Merged
Conversation
tvdeyen
approved these changes
May 5, 2025
Member
tvdeyen
left a comment
tvdeyen
left a comment
There was a problem hiding this comment.
This will add some churn to extension devs, but this is the right thing to do.
This will create a bit of work now, but aligns us with the rest of the community and - most importantly - stops us from having to maintain a set of coding conventions, which is no fun.
This moves this repository to be compliant with standardrb.
Member
|
Testing with solidusio-contrib/solidus_volume_pricing#76 |
jarednorman
requested changes
May 5, 2025
Member
jarednorman
left a comment
jarednorman
left a comment
There was a problem hiding this comment.
Can we add the formatting commit to .git-blame-ignore-revs. We should do this for each project that we reformat.
Member
|
I'm otherwise very in favor of this change. |
Contributor
Author
|
@jarednorman done, thanks for the idea! |
tvdeyen
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This switches our custom extension Rubocop.yml to using
standardrbinstead, allowing us to concentrate on actual issues rather than having to keep up with Rubocop.The following are not always needed: