Local ARS HLD by VladimirKuk · Pull Request #1958 · sonic-net/SONiC

VladimirKuk · 2025-04-08T11:56:07Z

This document provides high level design for the feature local Adaptive Routing and Switching (ARS).

PRs:

Repository	PR Title	State	Context
sonic-buildimage	`Local ARS (Adaptive Routing and Switching)`
sonic-swss	`Local ARS (Adaptive Routing and Switching)`
sonic-swss-common	`Local ARS (Adaptive Routing and Switching)`
sonic-mgmt	`Local ARS (Adaptive Routing and Switching test plan)`
sonic-mgmt	`Local ARS (Adaptive Routing and Switching test plan)`

Signed-off-by: Vladimir Kuk <vkuk@marvell.com>

Fixed phases contents Fixed spelling Added user configured port scaling factor Updated init sequence Limit idle time value Signed-off-by: Vladimir Kuk <vkuk@marvell.com>

mssonicbld · 2025-04-08T11:56:14Z

/azp run

azure-pipelines · 2025-04-08T11:56:21Z

No pipelines are associated with this pull request.

Yubin-Li · 2025-04-23T02:55:33Z

Why this schema used prefix for Key? dose it means that only some prefix can used with AR ECMP?

VladimirKuk · 2025-04-23T06:59:02Z

Why this schema used prefix for Key? dose it means that only some prefix can used with AR ECMP?

Yes, that is to support use-case for L3 traffic sent to NHG.
Also, currently, there is no other way to reference/identify NHG via CONFIG_DB.

Yubin-Li · 2025-04-23T11:47:28Z

Why this schema used prefix for Key? dose it means that only some prefix can used with AR ECMP?

Yes, that is to support use-case for L3 traffic sent to NHG. Also, currently, there is no other way to reference/identify NHG via CONFIG_DB.

If so, how to handle if there have 100 prefixes but point to same ECMP, we want to used AR for this ECMP. It's very hard to set dynamic route point to AR ecmp

I think may be we can define some AR ECMP include port list and trip threshold
for example, I define [port1,2,3,4,5] with AR ecmp, and trip threshold = 4
once we create ECMP with [1,2,3,4] [2,3,4,5], [1,2,3,4,5], we can create with AR

VladimirKuk · 2025-04-23T15:17:29Z

If so, how to handle if there have 100 prefixes but point to same ECMP, we want to used AR for this ECMP. It's very hard to set dynamic route point to AR ecmp

I think may be we can define some AR ECMP include port list and trip threshold for example, I define [port1,2,3,4,5] with AR ecmp, and trip threshold = 4 once we create ECMP with [1,2,3,4] [2,3,4,5], [1,2,3,4,5], we can create with AR

There is already ARS-enabled interface table, but it could include all interfaces, so I guess shouldn't be used for this. However, to create another table with ARS-enabled interfaces, feels very wasteful.

The problematic scenario is this : suppose you have two NHGs : NHG1 (NH1,NH2,NH3) and NHG2 (NH1,NH2,NH4).
NH3 and NH4 are not reliable and going up and down.
If you rely on ECMP updates to determine whether this is ARS NHG, you could mistake NHG1 with NHG2, since their content will be the same (NH1,NH2).
Prefix (while it is not ideal) is also, specifies the path you want to enable ARS for.

Also, the use-case was to enable static configuration, To enable dynamic NHG identification, the ARS/NHG ids should, probably, be derived from/imported by some protocol (i.e. BGP).

eddyk-nvidia · 2025-05-03T14:31:18Z

+        "max_flows" : "512",
+        "primary_path_threshold" : "100",
+        "alternative_path_cost": "250",
+        "alternative_path_members": {"1.1.1.1", "2.2.2.2"}


how do you in advance which NHs can be used when NHG is created from BGP by Route OA or FRR/Zebra ?

This should known to user

rajendrat · 2025-05-07T18:32:24Z

Why this schema used prefix for Key? dose it means that only some prefix can used with AR ECMP?

Yes, that is to support use-case for L3 traffic sent to NHG. Also, currently, there is no other way to reference/identify NHG via CONFIG_DB.

@VladimirKuk : Is there an option/way to enable ARS for all NH Groups or enable only for matching the "vrf/ip-prefix"?

Separated NHG identification and ARS object Added NHG matching by ARS-enabled members Support NH creation from RouteOrch and NhgOrch Signed-off-by: Vladimir Kuk <vkuk@marvell.com>

baxia-lan · 2025-10-08T00:09:28Z

+                description "ARS-enabled interface name";
+            }
+
+            leaf scaling_factor {


the definition of "scaling_factor" differs from SAI_PORT_ATTR_ARS_PORT_LOAD_SCALING_FACTOR and brings ambiguity.

scaling_factor: 10000
SAI_PORT_ATTR_ARS_PORT_LOAD_SCALING_FACTOR:40 # for 400G

Why not just set the value of SAI_PORT_ATTR_ARS_PORT_LOAD_SCALING_FACTOR to be value of scaling_factor?

scaling_factor: 40
SAI_PORT_ATTR_ARS_PORT_LOAD_SCALING_FACTOR:40 # for 400G

Previous changes handled cases where the speed was in MB. The current updates address review comments by using the SAI attribute instead.

Signed-off-by: Ashok Kumar P <apannerselva@marvell.com>

mssonicbld · 2025-10-08T10:24:32Z

/azp run

azure-pipelines · 2025-10-08T10:24:38Z

No pipelines are associated with this pull request.

New test plan for ARS HLD sonic-net/SONiC#1958 Signed-off-by: apannerselva <apannerselva@marvell.com>

New test plan for ARS HLD sonic-net/SONiC#1958 Signed-off-by: apannerselva <apannerselva@marvell.com> Signed-off-by: Venkata Gouri Rajesh Etla <vrajeshe@cisco.com>

* initial HLD version * review changes Signed-off-by: Vladimir Kuk <vkuk@marvell.com> * Identation fix Signed-off-by: Vladimir Kuk <vkuk@marvell.com> * Identation fix Signed-off-by: Vladimir Kuk <vkuk@marvell.com> * changes after initial review * update fonts * intergrated ARS_OBJECT in NHG and LAG, use notification mechanism * removed ARS_OBJECT * Update to latest changes Signed-off-by: Vladimir Kuk <vkuk@marvell.com> * Review changes Signed-off-by: Vladimir Kuk <vkuk@marvell.com> * Addressing comments Fixed phases contents Fixed spelling Added user configured port scaling factor Updated init sequence Limit idle time value Signed-off-by: Vladimir Kuk <vkuk@marvell.com> * Addressing comments Fixed phases contents Fixed spelling Added user configured port scaling factor Updated init sequence Limit idle time value Signed-off-by: Vladimir Kuk <vkuk@marvell.com> * Addressing community comments Separated NHG identification and ARS object Added NHG matching by ARS-enabled members Support NH creation from RouteOrch and NhgOrch Signed-off-by: Vladimir Kuk <vkuk@marvell.com> * Fixing Review comments Signed-off-by: Ashok Kumar P <apannerselva@marvell.com> --------- Signed-off-by: Vladimir Kuk <vkuk@marvell.com> Signed-off-by: Ashok Kumar P <apannerselva@marvell.com> Signed-off-by: Eddie Ruan <eddie.ruan@alibaba-inc.com>

New test plan for ARS HLD sonic-net/SONiC#1958 Signed-off-by: apannerselva <apannerselva@marvell.com> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>

New test plan for ARS HLD sonic-net/SONiC#1958 Signed-off-by: apannerselva <apannerselva@marvell.com>

New test plan for ARS HLD sonic-net/SONiC#1958 Signed-off-by: apannerselva <apannerselva@marvell.com> Signed-off-by: Raghavendran Ramanathan <rraghav@cisco.com>

Added support for local ARS (Adaptive Routing and Switching). HLD: sonic-net/SONiC#1958 Signed-off-by: VladimirKuk <31180446+VladimirKuk@users.noreply.github.com>

Description of PR New test plan for Adaptive Routing and Switching HLD [sonic-net/SONiC#1958] Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202311 202405 202411 202505 202511 202512 202605 Approach What is the motivation for this PR? New test plan for ARS HLD [sonic-net/SONiC#1958] How did you do it? Added ARS test plan covering adaptive routing and switching functionality. How did you verify/test it? Ran it on the device Results - ecmp/ars/test_ars.py::test_ars_modes[per-packet-global] PASSED [ 10%] ecmp/ars/test_ars.py::test_ars_modes[per-packet-interface] PASSED [ 20%] ecmp/ars/test_ars.py::test_ars_modes[per-packet-nexthop] PASSED [ 30%] ecmp/ars/test_ars.py::test_ars_modes[per-flowlet-global] PASSED [ 40%] ecmp/ars/test_ars.py::test_ars_modes[per-flowlet-interface] PASSED [ 50%] ecmp/ars/test_ars.py::test_ars_modes[per-flowlet-nexthop] PASSED [ 60%] ecmp/ars/test_ars.py::test_ars_acl_action PASSED [ 70%] ecmp/ars/test_ars.py::test_ars_nonars_interface[interface] PASSED [ 80%] ecmp/ars/test_ars.py::test_ars_nonars_interface[nexthop] PASSED [ 90%] ecmp/ars/test_ars.py::test_ars_stress PASSED [100%] Any platform specific information? To be supported for ARS supported platforms and now the script is supported only for marvell-teralynx Supported testbed topology if it's a new test case? T0 Topology Signed-off-by: Ashok Kumar P <apannerselva@marvell.com>

Added support for local ARS (Adaptive Routing and Switching). HLD: sonic-net/SONiC#1958 Signed-off-by: VladimirKuk <31180446+VladimirKuk@users.noreply.github.com>

VladimirKuk added 12 commits December 17, 2024 11:22

initial HLD version

e1a5928

review changes

b7fc309

Signed-off-by: Vladimir Kuk <vkuk@marvell.com>

Identation fix

df5a17c

Signed-off-by: Vladimir Kuk <vkuk@marvell.com>

Identation fix

6cb1875

Signed-off-by: Vladimir Kuk <vkuk@marvell.com>

changes after initial review

5999c60

update fonts

85308e5

intergrated ARS_OBJECT in NHG and LAG, use notification mechanism

c543eac

removed ARS_OBJECT

e1ed0c7

Update to latest changes

e2cf03a

Signed-off-by: Vladimir Kuk <vkuk@marvell.com>

Review changes

f9591b1

Signed-off-by: Vladimir Kuk <vkuk@marvell.com>

Addressing comments

ed8b67c

Fixed phases contents Fixed spelling Added user configured port scaling factor Updated init sequence Limit idle time value Signed-off-by: Vladimir Kuk <vkuk@marvell.com>

Addressing comments

adda601

Fixed phases contents Fixed spelling Added user configured port scaling factor Updated init sequence Limit idle time value Signed-off-by: Vladimir Kuk <vkuk@marvell.com>

This was referenced Apr 8, 2025

Local ARS (Adaptive Routing and Switching) sonic-net/sonic-buildimage#22264

Open

Local ARS (Adaptive Routing and Switching) sonic-net/sonic-swss#3597

Open

Local ARS (Adaptive Routing and Switching) sonic-net/sonic-swss-common#1002

Open

Yuval-Mellanox requested a review from eddyk-nvidia April 23, 2025 05:37

eddyk-nvidia reviewed May 3, 2025

View reviewed changes

rck-innovium mentioned this pull request May 9, 2025

Local Adaptive Routing #1868

Open

ashutosh-agrawal reviewed May 9, 2025

View reviewed changes

Comment thread doc/ARS/Local_ARS_HLD.md Outdated

ashutosh-agrawal reviewed May 9, 2025

View reviewed changes

Comment thread doc/ARS/Local_ARS_HLD.md

ashutosh-agrawal reviewed May 9, 2025

View reviewed changes

Comment thread doc/ARS/Local_ARS_HLD.md Outdated

ashutosh-agrawal reviewed May 10, 2025

View reviewed changes

Comment thread doc/ARS/Local_ARS_HLD.md Outdated

Addressing community comments

328b787

Separated NHG identification and ARS object Added NHG matching by ARS-enabled members Support NH creation from RouteOrch and NhgOrch Signed-off-by: Vladimir Kuk <vkuk@marvell.com>

baxia-lan reviewed Oct 8, 2025

View reviewed changes

Fixing Review comments

d80f2f3

Signed-off-by: Ashok Kumar P <apannerselva@marvell.com>

apannerselva force-pushed the local_ARS branch from 3f68657 to d80f2f3 Compare October 8, 2025 10:24

apannerselva mentioned this pull request Nov 7, 2025

[New Feature] ARS test plan sonic-net/sonic-mgmt#21237

Merged

11 tasks

rck-innovium removed this from SONiC 202511 Release Jan 13, 2026

rck-innovium added this to SONiC 202605 Release Jan 13, 2026

github-project-automation Bot moved this to Todo in SONiC 202605 Release Jan 13, 2026

rck-innovium moved this from Todo to In Progress in SONiC 202605 Release Jan 13, 2026

venkatmahalingam approved these changes Feb 12, 2026

View reviewed changes

lihuay approved these changes Feb 19, 2026

View reviewed changes

lihuay merged commit 795c61b into sonic-net:master Feb 19, 2026
1 check passed

github-project-automation Bot moved this from In Progress to Done in SONiC 202605 Release Feb 19, 2026

rck-innovium moved this from Done to In Progress in SONiC 202605 Release Mar 10, 2026

yxieca pushed a commit to sonic-net/sonic-mgmt that referenced this pull request Mar 20, 2026

ARS test plan (#21237)

d8d7366

New test plan for ARS HLD sonic-net/SONiC#1958 Signed-off-by: apannerselva <apannerselva@marvell.com>

albertovillarreal-keys pushed a commit to albertovillarreal-keys/sonic-mgmt that referenced this pull request Apr 3, 2026

ARS test plan (sonic-net#21237)

c201dae

New test plan for ARS HLD sonic-net/SONiC#1958 Signed-off-by: apannerselva <apannerselva@marvell.com>

apannerselva mentioned this pull request May 25, 2026

ARS test script sonic-net/sonic-mgmt#24845

Open

12 tasks

Conversation

VladimirKuk commented Apr 8, 2025 • edited by radha-danda Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mssonicbld commented Apr 8, 2025

Uh oh!

azure-pipelines Bot commented Apr 8, 2025

Uh oh!

Yubin-Li commented Apr 23, 2025

Uh oh!

VladimirKuk commented Apr 23, 2025

Uh oh!

Yubin-Li commented Apr 23, 2025

Uh oh!

VladimirKuk commented Apr 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eddyk-nvidia May 3, 2025

Choose a reason for hiding this comment

Uh oh!

VladimirKuk May 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rajendrat commented May 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

baxia-lan Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

apannerselva Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

mssonicbld commented Oct 8, 2025

Uh oh!

azure-pipelines Bot commented Oct 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

VladimirKuk commented Apr 8, 2025 •

edited by radha-danda

Loading