Skip to content

Local ARS (Adaptive Routing and Switching)#1002

Open
VladimirKuk wants to merge 1 commit into
sonic-net:masterfrom
Marvell-switching:mrvl-local-ARS
Open

Local ARS (Adaptive Routing and Switching)#1002
VladimirKuk wants to merge 1 commit into
sonic-net:masterfrom
Marvell-switching:mrvl-local-ARS

Conversation

@VladimirKuk
Copy link
Copy Markdown

Added support for local ARS (Adaptive Routing and Switching).

HLD: sonic-net/SONiC#1958

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Comment thread common/schema.h Outdated
#define PLUGIN_TABLE "PLUGIN_TABLE"
#define LUA_PLUGIN_TYPE "LUA_PLUGIN_TYPE"
#define SAI_OBJECT_TYPE "SAI_OBJECT_TYPE"
#define PFC_WD_POLL_MSECS 100
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the changes not applicable to this feature

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

Comment thread common/schema.h Outdated
#define BMP_STATE_BGP_RIB_IN_TABLE "BGP_RIB_IN_TABLE"
#define BMP_STATE_BGP_RIB_OUT_TABLE "BGP_RIB_OUT_TABLE"

/* ARS */
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to move to lint602 with other state db table names.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed it

Comment thread common/schema.h Outdated

#define CFG_ARS_PROFILE "ARS_PROFILE"
#define CFG_ARS_INTERFACE "ARS_INTERFACE"
#define CFG_ARS_NEXTHOP_GROUP "ARS_NEXTHOP_GROUP"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz check the latest changes.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CFG_ macros are auto-generated from YANG models via cfg_schema.h. hence, this changes are removed from schema.h

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Comment thread common/schema.h
#define APP_SWITCH_TABLE_NAME "SWITCH_TABLE"
#define APP_NEXTHOP_GROUP_TABLE_NAME "NEXTHOP_GROUP_TABLE"
#define APP_CLASS_BASED_NEXT_HOP_GROUP_TABLE_NAME "CLASS_BASED_NEXT_HOP_GROUP_TABLE"
#define APP_EVPN_SPLIT_HORIZON_TABLE_NAME "EVPN_SPLIT_HORIZON_TABLE"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove existing definition?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of a merge conflict the file was removed, and i have restored it now.

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@apannerselva
Copy link
Copy Markdown

/azpw run Azure.sonic-swss-common (Test vstest)

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run Azure.sonic-swss-common (Test vstest)

@azure-pipelines
Copy link
Copy Markdown

No pipelines are associated with this pull request.

@rck-innovium
Copy link
Copy Markdown

/azpw run Azure.sonic-swss-common (Test vstest)

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run Azure.sonic-swss-common (Test vstest)

@azure-pipelines
Copy link
Copy Markdown

No pipelines are associated with this pull request.

@rck-innovium
Copy link
Copy Markdown

hi @prsunny We have addressed all the open comments. Can you please review and merge.

@rustiqly
Copy link
Copy Markdown
Contributor

/azp run

@radha-danda
Copy link
Copy Markdown

/azpw run

@mssonicbld
Copy link
Copy Markdown
Collaborator

⚠️ Notice: /azpw run only runs failed jobs now. If you want to trigger a whole pipline run, please rebase your branch or close and reopen the PR.
💡 Tip: You can also use /azpw retry to retry failed jobs directly.

Retrying failed(or canceled) jobs...

@mssonicbld
Copy link
Copy Markdown
Collaborator

Build not found. Please close and reopen the PR or rebase your branch to trigger a new build.

@radha-danda
Copy link
Copy Markdown

/azpw run Azure.sonic-swss-common

@mssonicbld
Copy link
Copy Markdown
Collaborator

⚠️ Notice: /azpw run only runs failed jobs now. If you want to trigger a whole pipline run, please rebase your branch or close and reopen the PR.
💡 Tip: You can also use /azpw retry to retry failed jobs directly.

Retrying failed(or canceled) jobs...

@mssonicbld
Copy link
Copy Markdown
Collaborator

Build not found. Please close and reopen the PR or rebase your branch to trigger a new build.

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@radha-danda radha-danda reopened this May 19, 2026
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@radha-danda
Copy link
Copy Markdown

/azpw run

@mssonicbld
Copy link
Copy Markdown
Collaborator

⚠️ Notice: /azpw run only runs failed jobs now. If you want to trigger a whole pipline run, please rebase your branch or close and reopen the PR.
💡 Tip: You can also use /azpw retry to retry failed jobs directly.

Retrying failed(or canceled) jobs...

@mssonicbld
Copy link
Copy Markdown
Collaborator

Retrying failed(or canceled) stages in build 1117393:

✅Stage Test:

  • Job vstest: retried.

@apannerselva
Copy link
Copy Markdown

/azpw retry

@mssonicbld
Copy link
Copy Markdown
Collaborator

Retrying failed(or canceled) jobs...

@mssonicbld
Copy link
Copy Markdown
Collaborator

Retrying failed(or canceled) stages in build 1117393:

✅Stage Test:

  • Job vstest: retried.

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@radha-danda
Copy link
Copy Markdown

/azpw run

@mssonicbld
Copy link
Copy Markdown
Collaborator

⚠️ Notice: /azpw run only runs failed jobs now. If you want to trigger a whole pipline run, please rebase your branch or close and reopen the PR.
💡 Tip: You can also use /azpw retry to retry failed jobs directly.

Retrying failed(or canceled) jobs...

@mssonicbld
Copy link
Copy Markdown
Collaborator

Retrying failed(or canceled) stages in build 1122058:

✅Stage Build:

  • Job amd64: retried.
  • Job amd64/ubuntu-22.04: retried.

Added support for local ARS (Adaptive Routing and Switching).

HLD: sonic-net/SONiC#1958

Signed-off-by: VladimirKuk <31180446+VladimirKuk@users.noreply.github.com>
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@apannerselva
Copy link
Copy Markdown

@prsunny please review the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants