Local ARS (Adaptive Routing and Switching)#1002
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| #define PLUGIN_TABLE "PLUGIN_TABLE" | ||
| #define LUA_PLUGIN_TYPE "LUA_PLUGIN_TYPE" | ||
| #define SAI_OBJECT_TYPE "SAI_OBJECT_TYPE" | ||
| #define PFC_WD_POLL_MSECS 100 |
There was a problem hiding this comment.
Please revert the changes not applicable to this feature
| #define BMP_STATE_BGP_RIB_IN_TABLE "BGP_RIB_IN_TABLE" | ||
| #define BMP_STATE_BGP_RIB_OUT_TABLE "BGP_RIB_OUT_TABLE" | ||
|
|
||
| /* ARS */ |
There was a problem hiding this comment.
Better to move to lint602 with other state db table names.
|
|
||
| #define CFG_ARS_PROFILE "ARS_PROFILE" | ||
| #define CFG_ARS_INTERFACE "ARS_INTERFACE" | ||
| #define CFG_ARS_NEXTHOP_GROUP "ARS_NEXTHOP_GROUP" |
There was a problem hiding this comment.
also ARS_OBJECT table as per https://github.com/sonic-net/SONiC/pull/1958/files ?
There was a problem hiding this comment.
CFG_ macros are auto-generated from YANG models via cfg_schema.h. hence, this changes are removed from schema.h
340fb58 to
ade1897
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ade1897 to
b3164ac
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| #define APP_SWITCH_TABLE_NAME "SWITCH_TABLE" | ||
| #define APP_NEXTHOP_GROUP_TABLE_NAME "NEXTHOP_GROUP_TABLE" | ||
| #define APP_CLASS_BASED_NEXT_HOP_GROUP_TABLE_NAME "CLASS_BASED_NEXT_HOP_GROUP_TABLE" | ||
| #define APP_EVPN_SPLIT_HORIZON_TABLE_NAME "EVPN_SPLIT_HORIZON_TABLE" |
There was a problem hiding this comment.
Why remove existing definition?
There was a problem hiding this comment.
Because of a merge conflict the file was removed, and i have restored it now.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
d9f7cd7 to
95cfa52
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
95cfa52 to
be2ac51
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-swss-common (Test vstest) |
|
/AzurePipelines run Azure.sonic-swss-common (Test vstest) |
|
No pipelines are associated with this pull request. |
|
/azpw run Azure.sonic-swss-common (Test vstest) |
|
/AzurePipelines run Azure.sonic-swss-common (Test vstest) |
|
No pipelines are associated with this pull request. |
|
hi @prsunny We have addressed all the open comments. Can you please review and merge. |
|
/azp run |
|
/azpw run |
|
Retrying failed(or canceled) jobs... |
|
Build not found. Please close and reopen the PR or rebase your branch to trigger a new build. |
|
/azpw run Azure.sonic-swss-common |
|
Retrying failed(or canceled) jobs... |
|
Build not found. Please close and reopen the PR or rebase your branch to trigger a new build. |
be2ac51 to
ebfcc6b
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
Retrying failed(or canceled) jobs... |
|
Retrying failed(or canceled) stages in build 1117393: ✅Stage Test:
|
|
/azpw retry |
|
Retrying failed(or canceled) jobs... |
|
Retrying failed(or canceled) stages in build 1117393: ✅Stage Test:
|
ebfcc6b to
0ee673b
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
Retrying failed(or canceled) jobs... |
|
Retrying failed(or canceled) stages in build 1122058: ✅Stage Build:
|
Added support for local ARS (Adaptive Routing and Switching). HLD: sonic-net/SONiC#1958 Signed-off-by: VladimirKuk <31180446+VladimirKuk@users.noreply.github.com>
0ee673b to
df62e71
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@prsunny please review the changes. |
Added support for local ARS (Adaptive Routing and Switching).
HLD: sonic-net/SONiC#1958